Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

test: test svg scenario. #176#177

Merged
alexander-akait merged 2 commits into
webpack-contrib:masterfrom
Jeff-Tian:master
Apr 4, 2019
Merged

test: test svg scenario. #176#177
alexander-akait merged 2 commits into
webpack-contrib:masterfrom
Jeff-Tian:master

Conversation

@Jeff-Tian

Copy link
Copy Markdown
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

There are some doubts both on stackoverflow and github(#6, wbkd/webpack-starter#2) on this package about inline svg not working. So this change added a test case for svg scenario to prove that svg indeed works here.

The value of this change is if someone met the svg not work in their project, then they can exclude the doubt of this package and go directly to spot the issues by investigating other packages.

Breaking Changes

N.A.

Additional Info

@jsf-clabot

jsf-clabot commented Apr 1, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@alexander-akait

Copy link
Copy Markdown
Member

Please accept CLA

@Jeff-Tian

Copy link
Copy Markdown
Contributor Author

@evilebottnawi thank you, accepted.

@alexander-akait
alexander-akait merged commit a6705cc into webpack-contrib:master Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants