This repository was archived by the owner on Mar 17, 2021. It is now read-only.
fix(utils/normalizeFallback): correctly pass all options to the default fallback (file-loader)#139
Merged
michael-ciniawsky merged 2 commits intowebpack-contrib:masterfrom Aug 15, 2018
insin:default-fallback-options
Merged
fix(utils/normalizeFallback): correctly pass all options to the default fallback (file-loader)#139michael-ciniawsky merged 2 commits intowebpack-contrib:masterfrom insin:default-fallback-options
options to the default fallback (file-loader)#139michael-ciniawsky merged 2 commits intowebpack-contrib:masterfrom
insin:default-fallback-options
Conversation
Member
|
Wait review and we will release |
src/utils/normalizeFallback.js
Outdated
| return { | ||
| loader: fallbackString, | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
We really need in this? Looks better always return query.
michael-ciniawsky
changed the title
options to the default fallback (file-loader)
Member
|
The |
6 tasks
|
@evilebottnawi can you publish a new version |
Member
|
@zhangyuheng Soon we are discussing this and try to release a fix asap |
This was referenced Aug 16, 2018
Member
|
Released in |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #138 by passing on all non-
url-loaderoptions when defaulting tofile-loaderas the fallback.This also implements the suggestion which was previously in a code comment to strip out url-loader specific options when passing them to the fallback - this shouldn't be a breaking change as they were never accepted by
file-loader.Breaking Changes
Should undo a breaking change for people who depended on options being passed on to
file-loader😹Additional Info
❤️