Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

Comments

refactor: webpack-defaults#129

Merged
shellscape merged 3 commits intomasterfrom
refactor/defaults
Jun 16, 2018
Merged

refactor: webpack-defaults#129
shellscape merged 3 commits intomasterfrom
refactor/defaults

Conversation

@shellscape
Copy link
Contributor

This PR updates the repo to the latest webpack-defaults. Major improvements in tooling, github templates, and metadata.

@alexander-akait
Copy link
Member

@shellscape what is wrong with node9-latest? 😕

@shellscape
Copy link
Contributor Author

@evilebottnawi all odd-numbered releases of node are not covered by LTS, so they're not officially supported. see https://github.com/nodejs/Release and search for "odd"

@alexander-akait
Copy link
Member

@shellscape i know, just strange what it is hangs, feel free to merge 👍

@alexander-akait
Copy link
Member

/cc @shellscape looks node9-latest hangs. how we can solve this and merge this PR? Any ideas?

@shellscape
Copy link
Contributor Author

@evilebottnawi that's a leftover from the previous circle CI config and is no longer run (only 6, 8 , and 10 now). I believe this can be merged OK

@alexander-akait
Copy link
Member

@shellscape can't have access to merge

All required statuses and check runs on this pull request must run successfully to enable automatic merging.

@shellscape
Copy link
Contributor Author

OK given that we've got approval and you're blocked merging this, I'll use admin privs and merge it.

@shellscape shellscape merged commit 9946374 into master Jun 16, 2018
@shellscape shellscape deleted the refactor/defaults branch June 16, 2018 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants