Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 25, 2022

Bumps eslint-plugin-mdx from 2.0.1 to 2.0.2.

Release notes

Sourced from eslint-plugin-mdx's releases.

v2.0.2

2.0.2

Patch Changes

Commits
  • c9c012f docs: update incorrect PR link text
  • 7806ac5 docs: update changelog (#416)
  • 1b0d640 chore: fix access in .changeset
  • 57bbfb3 chore: release package(s) (#415)
  • 3bbe033 ci: use fixed versions of changesets
  • 28d51a0 ci: add missing build step
  • 58e529c ci: migrate lerna to changesets (#414)
  • 52030ac chore: we are not using changeset in this project
  • e697910 fix: resolve circular imports in worker (#412)
  • 89a83a6 ci: use pull_request_target for pkg-size
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 25, 2022
@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 7:13PM (UTC)

@chenxsan
Copy link
Member

@JounQin Wondering if something's broken in 2.0.2,

CleanShot 2022-07-26 at 13 03 10@2x

Here's how you can reproduce it:

  1. clone this pull request
  2. run yarn to install deps
  3. run ./node_modules/.bin/eslint --debug src/content/branding.mdx

@JounQin
Copy link
Member

JounQin commented Jul 26, 2022

Thanks for pining, I'll take a look when I'm free today.

cc @EdisonSu768

@JounQin
Copy link
Member

JounQin commented Jul 26, 2022

@chenxsan https://github.com/webpack/webpack.js.org/runs/7514398471?check_suite_focus=true#step:5:348

There seems to be something non-clonable by synckit, not quite sure what it could be yet, will try to debug after work.

@JounQin
Copy link
Member

JounQin commented Jul 26, 2022

@chenxsan See #6300, it seems there are two different acorn versions installed, that cause this issue, I've run npx yarn-deduplicate --strategy fewer to deduplicate them, and will find out what can we do on eslint-mdx's side.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 26, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/eslint-plugin-mdx-2.0.2 branch July 26, 2022 12:58
@chenxsan
Copy link
Member

@chenxsan See #6300, it seems there are two different acorn versions installed, that cause this issue, I've run npx yarn-deduplicate --strategy fewer to deduplicate them, and will find out what can we do in eslint-mdx's side.

Awesome, thanks for help!

@JounQin
Copy link
Member

JounQin commented Jul 26, 2022

@chenxsan

It seems we can't do much on eslint-mdx's side, it requires same acorn package shared with micromark-extension-mdxjs, but it seems no way to ensure that.

By the mean time, I think we should enable yarn-deduplicate --strategy fewer in this repository.

@chenxsan
Copy link
Member

@chenxsan

It seems we can't do much on eslint-mdx's side, it requires same acorn package shared with micromark-extension-mdxjs, but it seems no way to ensure that.

By the mean time, I think we should enable yarn-deduplicate --strategy fewer in this repository.

feel free to send a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants