Skip to content

Shorten Intro and Entry point description #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zastavnitskiy
Copy link

Guys, check this attempt to make the doc shorter and easier to read. I think it will improve the readability, as it removed some extra overhead without losing the important information.

If you think it's a good direction to move to, I can proceed with more edits.

@jsf-clabot
Copy link

jsf-clabot commented Nov 17, 2016

CLA assistant check
All committers have signed the CLA.


## Entry

webpack creates a graph of all of your application's dependencies. The starting point of this graph is known as an _entry point_. The _entry point_ tells webpack _where to start_ and follows the graph of dependencies to know _what to bundle_. You can think of your application's _entry point_ as the **contextual root** or **the first file to kick off your app**.
Webpack creates a graph of all of your application's dependencies. The root node of dependencies graph is known as an _entry point_. The _entry point_ tells webpack _where to start_ and follows the graph of dependencies to know _what to bundle_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Webpack/webpack/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It's a new sentence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceK33z
Copy link
Member

SpaceK33z commented Nov 19, 2016

@TheLarkInn, what do you think of this change?

This assumes that the reader knows what a "root node" of a dependency graph is. I'm not completely sure if everybody knows what that is?

@bebraw
Copy link
Contributor

bebraw commented Nov 21, 2016

Yeah, it's probably best not to assume too much of the readers as not all are versed with graph theory. A good visualization would actually help a lot here.

@TheLarkInn
Copy link
Member

I agree with @bebraw, if we do remove content some sort of graphic I think would be really beneficial.

@bebraw bebraw changed the base branch from develop to master January 1, 2017 13:52
@bebraw
Copy link
Contributor

bebraw commented Jan 1, 2017

Can you rebase against master? The development happens against it now (faster deployments).

@bebraw
Copy link
Contributor

bebraw commented Jan 22, 2017

Can you resolve the conflicts and do the changes requested? Thanks.

@bebraw
Copy link
Contributor

bebraw commented Jan 31, 2017

I'll close this for now. Feel free to rebase and re-open if/when you have time.

@bebraw bebraw closed this Jan 31, 2017
guyunxiang pushed a commit to guyunxiang/webpack.js.org that referenced this pull request Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants