docs(dev-server.md): Clarify the possible return value for devServer.…#3211
Merged
EugeneHlushko merged 7 commits intoAug 13, 2019
Merged
Conversation
6 tasks
|
Preview is ready Built with commit 244d82f |
montogeek
approved these changes
Jul 25, 2019
Contributor
Author
|
Hi. Can someone merge the PR for me? Thanks. |
|
@randing89 could you please merge with the last master? |
Contributor
Author
|
@mistic done |
EugeneHlushko
suggested changes
Aug 5, 2019
EugeneHlushko
left a comment
EugeneHlushko
left a comment
Contributor
There was a problem hiding this comment.
Suggesting a small change to the text, a question on :void
Co-Authored-By: Eugene Hlushko <[email protected]>
Co-Authored-By: Eugene Hlushko <[email protected]>
Co-Authored-By: Eugene Hlushko <[email protected]>
rishabh3112
approved these changes
Aug 11, 2019
randing89
commented
Aug 11, 2019
randing89
left a comment
randing89
left a comment
Contributor
Author
There was a problem hiding this comment.
I have addressed all the suggestions
montogeek
approved these changes
Aug 11, 2019
EugeneHlushko
approved these changes
Aug 13, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better align the docs with the code changes here: webpack/webpack-dev-server#1696 (comment)
The doc was ambiguous about what
falsereturn values does.