Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - Allow Illustrations Via Mermaid #469

Open
4 tasks
pastelsky opened this issue Dec 4, 2016 · 23 comments
Open
4 tasks

Dev - Allow Illustrations Via Mermaid #469

pastelsky opened this issue Dec 4, 2016 · 23 comments

Comments

@pastelsky
Copy link
Collaborator

pastelsky commented Dec 4, 2016

Webpack documentation can get a little text heavy at times. As discussed in several other threads (eg. #349), adding illustrations and screenshots would help add visual relief.

Starting with the concepts site section, we can identify critical topics that would benefit from visualisations, and I could help make them. After we identify such topics, I will post the graphic as a issue / PR which we can then discuss. I can make the final edits accordingly.

As a proof of concept, I made the following graphic for the "Entry" section in concepts.

entry-graph copy

I've kept the style very casual and informal, which should help with webpack's image of being "tough" and "not beginner friendly".

I'd love to hear which sections we should concentrate on, and if someone has a neat idea for a graphic, feel free to post, even if its a screenshot of a hand-drawn pencil sketch. It's going to prove to be very helpful.

Update

It seems we've all agreed on mermaid and we already have a few charts started stemming from various issues. Here's what it sounds like is needed to push it this forward:

@pksjce
Copy link

pksjce commented Dec 4, 2016 via email

@pastelsky
Copy link
Collaborator Author

pastelsky commented Dec 4, 2016

Thanks @pksjce. Though including inline images in the current markdown setup wouldn't be a straightforward task. We'll probably have to host these images on webpack.js.org's server before we can link them in the markdown.

@pastelsky
Copy link
Collaborator Author

@bebraw @skipjack @SpaceK33z what do you guys think? should I go forward with this?

@bebraw
Copy link
Contributor

bebraw commented Dec 10, 2016

@pastelsky Yeah, sure. Would it be possible for you to share the style (push to webpack/media) so it's easier to keep it consistent across the documentation? #473 is related to this.

I wonder if it would be possible to create a nice style for graphviz. That would allow even coders to generate nice graphics.

@pastelsky
Copy link
Collaborator Author

@bebraw Sure. I can share the textures, fonts and shapes used. Although the graphic will still have to be created manually in a vector editor like sketch. I do not know much about graphviz.

@bebraw
Copy link
Contributor

bebraw commented Dec 11, 2016

@pastelsky Essentially graphviz is based on a text based tree definition. It renders the images for you. Taken far enough it would be possible to make it so that you can write the definitions within Markdown and the system will render them as images while applying the project specific style.

The big advantage of going through a definition based approach like this is that then it's easier to get something consistent looking. You lose some power since it does the layout for you.

@skipjack
Copy link
Collaborator

@pastelsky looks great, yea I definitely think we should go forward with this. I agree with @bebraw that enforcing a consistent style would be best (whatever method we choose for that). This is something @jhnns and I discussed a while back in regards to displaying modules in graphs/illustrations. He might be a good person to discuss this with as well -- any thoughts @jhnns?

@jaydenseric
Copy link

My thoughts on the graphic style is that it would not work well as SVG, due to the grungy smudges. Where possible all logos and diagrams should be SVG. I suggest changing the watercolor fills to a flat color, the borders should be ok as outlines.

@pastelsky
Copy link
Collaborator Author

pastelsky commented Jan 12, 2017 via email

@bebraw
Copy link
Contributor

bebraw commented Jan 19, 2017

@pastelsky Another option, https://github.com/knsv/mermaid . We could integrate that to markdown quite easily.

@rouzbeh84
Copy link
Collaborator

rouzbeh84 commented Mar 2, 2017

mermaid is pretty cool! got it started here mermaidGraph but it could definitely use some styling love haha.

i can get back at it tomorrow a bit though. Would love to look into it a bit further as a nested graph may not be best option but I was trying to emulate the image as best I could (thanks @pastelsky!)

@pastelsky
Copy link
Collaborator Author

pastelsky commented Mar 3, 2017 via email

@rouzbeh84
Copy link
Collaborator

yea, sorry i didn't get a chance to style it up more. it does allow for pretty easy CSS styling though so it can be quite easily styled if you check out the bottom of the code in the link.

@skipjack skipjack changed the title Proposal: Adding illustrations to webpack documentation Dev - Allow Illustrations Jun 14, 2017
@skipjack
Copy link
Collaborator

Related: #473

@rouzbeh84
Copy link
Collaborator

@skipjack very related. I think mermaid is a very cool to for this kind of stuff. FYI the link above for the image is still live here

@skipjack
Copy link
Collaborator

@rouzbeh84 yeah and I'm definitely glad you started playing around with it -- this would be an awesome thing to push forward when we can.

Another related one: #487

@pastelsky
Copy link
Collaborator Author

Mermaid with custom styling looks pretty good. If we can get a good color scheme to go with all of the diagrams, that would be great.

@skipjack
Copy link
Collaborator

I was also thinking about @jaydenseric's point about the grungy look:

My thoughts on the graphic style is that it would not work well as SVG, due to the grungy smudges. Where possible all logos and diagrams should be SVG. I suggest changing the watercolor fills to a flat color, the borders should be ok as outlines.

Seeing as it's just an SVG, we should be able to do this using a single "grungy" png for the background that's used in each element with a different color filter, but only loaded once. Although maybe I've overlooked something about how mermaid works.

@skipjack skipjack changed the title Dev - Allow Illustrations Dev - Allow Illustrations Via Mermaid Jun 25, 2017
@hulkish
Copy link
Collaborator

hulkish commented Jul 8, 2017

something like this could be a cool alternative to mermaid: https://www.jointjs.com/

@rouzbeh84
Copy link
Collaborator

rouzbeh84 commented Aug 10, 2017

@hulkish jointjs looks pretty awesome! do you know if they have a less expensive a.k.a free plan for OSS? I only saw a trial offered on their pricing page.

@skipjack
Copy link
Collaborator

@rouzbeh84 good question, I looked at this a while ago and was wondering the same thing. Also, I think there are some benefits to having a simpler text-based solution. I think it would be fairly easy to write a remark plugin (once we move to remark) that could use mermaid under the hood (e.g. remark-mermaid).

@skipjack
Copy link
Collaborator

skipjack commented Jan 7, 2018

Working on porting to remark now (and a variety of other things) on the rebuild branch. And... looks like somebody beat us to the chase with a remark-mermaid plugin! I'll install and test it out on that branch.

@skipjack skipjack mentioned this issue Apr 15, 2018
16 tasks
@montogeek
Copy link
Member

Rebuild branch was merged some time ago, @pastelsky Are you still interested in adding these diagrams?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants