-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev - Allow Illustrations Via Mermaid #469
Comments
I love this! I think that the concepts documentation would benefit most
from these. Also this would be great to explain webpack internals, the
compiler, compilation, resolver life cycles.
…On Sun, Dec 4, 2016 at 6:31 PM Shubham Kanodia ***@***.***> wrote:
Webpack documentation can get a little text heavy at times. As discussed
in several other issue threads, adding illustrations and screenshots would
help add visual relief.
Starting with the concepts site section, we can identify critical topics
that would benefit from visualisations, and I could help make them. After
we identify such topics, I will post the graphic as a issue / PR which we
can then discuss. I can make the final edits accordingly.
As a proof of concept, I made the following graphic for the "Entry"
section in concepts.
[image: entry-graph copy]
<https://cloud.githubusercontent.com/assets/8946207/20866237/47f1121e-ba4e-11e6-83b8-f4d14b3a0d79.png>
I've kept the style very casual and informal, which should help with
webpack's image of being "tough" and "not beginner friendly".
I'd love to hear which sections we should concentrate on, and if someone
has a neat idea for a graphic, feel free to post, even if its a screenshot
of a hand-drawn pencil sketch. It's going to prove to be very helpful.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#469>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZd9H4lwS7RI6_OaCMgnVXBoimWM2wJks5rErnEgaJpZM4LDlCh>
.
|
Thanks @pksjce. Though including inline images in the current markdown setup wouldn't be a straightforward task. We'll probably have to host these images on webpack.js.org's server before we can link them in the markdown. |
@bebraw @skipjack @SpaceK33z what do you guys think? should I go forward with this? |
@pastelsky Yeah, sure. Would it be possible for you to share the style (push to I wonder if it would be possible to create a nice style for graphviz. That would allow even coders to generate nice graphics. |
@bebraw Sure. I can share the textures, fonts and shapes used. Although the graphic will still have to be created manually in a vector editor like sketch. I do not know much about |
@pastelsky Essentially The big advantage of going through a definition based approach like this is that then it's easier to get something consistent looking. You lose some power since it does the layout for you. |
@pastelsky looks great, yea I definitely think we should go forward with this. I agree with @bebraw that enforcing a consistent style would be best (whatever method we choose for that). This is something @jhnns and I discussed a while back in regards to displaying modules in graphs/illustrations. He might be a good person to discuss this with as well -- any thoughts @jhnns? |
My thoughts on the graphic style is that it would not work well as SVG, due to the grungy smudges. Where possible all logos and diagrams should be SVG. I suggest changing the watercolor fills to a flat color, the borders should be ok as outlines. |
You're right. It's not just the background, but the casual look of the
strokes and fonts that'll make the svg version a bit heavy.
But then png's can look reasonably sharp on retina devices as well. And
png's are easier to share / reference / save. So it's a trade-off here.
The grunge fill was inspired in part by the graphic style on yarnpkg.org.
…On 12 Jan 2017 6:18 a.m., "Jayden Seric" ***@***.***> wrote:
My thoughts on the graphic style is that it would not work well as SVG,
due to the grungy smudges. Where possible all logos and diagrams should be
SVG. I suggest changing the watercolor fills to a flat color, the borders
should be ok as outlines.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#469 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIiCH7ggzSdrT_nmNMrpuUU5oeG3AwQ9ks5rRXhbgaJpZM4LDlCh>
.
|
@pastelsky Another option, https://github.com/knsv/mermaid . We could integrate that to markdown quite easily. |
mermaid is pretty cool! got it started here mermaidGraph but it could definitely use some styling love haha. i can get back at it tomorrow a bit though. Would love to look into it a bit further as a nested graph may not be best option but I was trying to emulate the image as best I could (thanks @pastelsky!) |
yea, sorry i didn't get a chance to style it up more. it does allow for pretty easy CSS styling though so it can be quite easily styled if you check out the bottom of the code in the link. |
Related: #473 |
@rouzbeh84 yeah and I'm definitely glad you started playing around with it -- this would be an awesome thing to push forward when we can. Another related one: #487 |
Mermaid with custom styling looks pretty good. If we can get a good color scheme to go with all of the diagrams, that would be great. |
I was also thinking about @jaydenseric's point about the grungy look:
Seeing as it's just an SVG, we should be able to do this using a single "grungy" png for the background that's used in each element with a different color filter, but only loaded once. Although maybe I've overlooked something about how mermaid works. |
something like this could be a cool alternative to mermaid: https://www.jointjs.com/ |
@hulkish jointjs looks pretty awesome! do you know if they have a less expensive a.k.a free plan for OSS? I only saw a trial offered on their pricing page. |
@rouzbeh84 good question, I looked at this a while ago and was wondering the same thing. Also, I think there are some benefits to having a simpler text-based solution. I think it would be fairly easy to write a remark plugin (once we move to remark) that could use mermaid under the hood (e.g. |
Working on porting to |
Rebuild branch was merged some time ago, @pastelsky Are you still interested in adding these diagrams? |
Webpack documentation can get a little text heavy at times. As discussed in several other threads (eg. #349), adding illustrations and screenshots would help add visual relief.
Starting with the concepts site section, we can identify critical topics that would benefit from visualisations, and I could help make them. After we identify such topics, I will post the graphic as a issue / PR which we can then discuss. I can make the final edits accordingly.
As a proof of concept, I made the following graphic for the "Entry" section in concepts.
I've kept the style very casual and informal, which should help with webpack's image of being "tough" and "not beginner friendly".
I'd love to hear which sections we should concentrate on, and if someone has a neat idea for a graphic, feel free to post, even if its a screenshot of a hand-drawn pencil sketch. It's going to prove to be very helpful.
Update
It seems we've all agreed on mermaid and we already have a few charts started stemming from various issues. Here's what it sounds like is needed to push it this forward:
The text was updated successfully, but these errors were encountered: