test: expand coverage for sources, helpers, and package entry#200
Merged
alexander-akait merged 2 commits intomainfrom Apr 21, 2026
Merged
test: expand coverage for sources, helpers, and package entry#200alexander-akait merged 2 commits intomainfrom
alexander-akait merged 2 commits intomainfrom
Conversation
Add targeted tests that exercise previously untested branches and edge cases: the abstract `Source` base class, `SizeOnlySource`'s `updateHash`, `CompatSource`'s optional delegates, `RawSource`'s type validation and Buffer-backed source path, `OriginalSource`'s `getName` and Buffer-backed map path, `ConcatSource`'s `buffer()` fallbacks and re-optimization paths, `PrefixSource`'s accessors and empty-prefix handling, `ReplaceSource`'s accessors, guards, hash stability, and edge cases, `CachedSource`'s lazy source accessor, hash flushing, map-only streamChunks, and Buffer round-tripping, and `SourceMapSource`'s string/buffer source-map variants and hash inclusion of `removeOriginalSource`. Add a dedicated helpers unit test file covering `getGeneratedSourceInfo`, `getSource`, `splitIntoLines`, `splitIntoPotentialTokens`, `readMappings`, `getFromStreamChunks`, `streamAndGetSourceAndMap`, and `stringBufferUtils`, including string-interning toggles and gap filling for non-sequential source/name indices.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 93.24% 98.07% +4.82%
==========================================
Files 25 25
Lines 1866 1866
Branches 595 596 +1
==========================================
+ Hits 1740 1830 +90
+ Misses 117 34 -83
+ Partials 9 2 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Store the freshly constructed CachedSource instances into a pre-sized sink array so V8 cannot dead-code-eliminate them and memory pressure stays consistent between samples. Overwriting existing slots (rather than push + length reset) keeps the sink's hidden class stable and avoids resize allocations during measurement. This reduces run-to-run variance that was surfacing as false codspeed regressions on this task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add targeted tests that exercise previously untested branches and
edge cases: the abstract
Sourcebase class,SizeOnlySource'supdateHash,CompatSource's optional delegates,RawSource'stype validation and Buffer-backed source path,
OriginalSource'sgetNameand Buffer-backed map path,ConcatSource'sbuffer()fallbacks and re-optimization paths,
PrefixSource's accessors andempty-prefix handling,
ReplaceSource's accessors, guards, hashstability, and edge cases,
CachedSource's lazy source accessor,hash flushing, map-only streamChunks, and Buffer round-tripping,
and
SourceMapSource's string/buffer source-map variants and hashinclusion of
removeOriginalSource. Add a dedicated helpers unittest file covering
getGeneratedSourceInfo,getSource,splitIntoLines,splitIntoPotentialTokens,readMappings,getFromStreamChunks,streamAndGetSourceAndMap, andstringBufferUtils, including string-interning toggles and gapfilling for non-sequential source/name indices.