refactor: drop redundant buffers() overrides that just return [this.buffer()]

claude · claude · commit a5034af32380 · 2026-04-28T15:42:09.000Z
Source.prototype.buffers() returns [this.buffer()] and naturally picks up subclass buffer() overrides through the prototype chain. The overrides on RawSource, OriginalSource, PrefixSource, and SourceMapSource simply repeated that same body, so remove them and let the base implementation handle those classes. ConcatSource, CachedSource, CompatSource, ReplaceSource, and SizeOnlySource keep their overrides since they each carry distinct logic (multi-buffer collection, caching, SourceLike delegation, no-replacements pass-through, throwing). Source.prototype.buffers() reverts from the inlined source()-based implementation back to [this.buffer()], so subclass buffer() optimizations (cached _valueAsBuffer in RawSource etc.) flow through without duplication. https://claude.ai/code/session_01EHhGq9PRFRGefVtwwasCqZ
diff --git a/lib/OriginalSource.js b/lib/OriginalSource.js
@@ -82,13 +82,6 @@ class OriginalSource extends Source {
 		return this._valueAsBuffer;
 	}
 
-	/**
-	 * @returns {Buffer[]} buffers
-	 */
-	buffers() {
-		return [this.buffer()];
-	}
-
 	/**
 	 * Override Source.prototype.size (= `this.buffer().length`) to avoid
 	 * allocating a Buffer just to read the byte length, and memoize the
diff --git a/lib/PrefixSource.js b/lib/PrefixSource.js
@@ -64,13 +64,6 @@ class PrefixSource extends Source {
 
 	// TODO efficient buffer() implementation
 
-	/**
-	 * @returns {Buffer[]} buffers
-	 */
-	buffers() {
-		return [this.buffer()];
-	}
-
 	/**
 	 * @param {MapOptions=} options map options
 	 * @returns {RawSourceMap | null} map
diff --git a/lib/RawSource.js b/lib/RawSource.js
@@ -93,13 +93,6 @@ class RawSource extends Source {
 		return this._valueAsBuffer;
 	}
 
-	/**
-	 * @returns {Buffer[]} buffers
-	 */
-	buffers() {
-		return [this.buffer()];
-	}
-
 	/**
 	 * Override Source.prototype.size (= `this.buffer().length`) to avoid
 	 * allocating a Buffer just to read the byte length, and memoize the
diff --git a/lib/Source.js b/lib/Source.js
@@ -59,9 +59,7 @@ class Source {
 	 * @returns {Buffer[]} buffers
 	 */
 	buffers() {
-		const source = this.source();
-		if (Buffer.isBuffer(source)) return [source];
-		return [Buffer.from(source, "utf8")];
+		return [this.buffer()];
 	}
 
 	size() {
diff --git a/lib/SourceMapSource.js b/lib/SourceMapSource.js
@@ -143,13 +143,6 @@ class SourceMapSource extends Source {
 		return this._valueAsBuffer;
 	}
 
-	/**
-	 * @returns {Buffer[]} buffers
-	 */
-	buffers() {
-		return [this.buffer()];
-	}
-
 	/**
 	 * Override Source.prototype.size (= `this.buffer().length`) to avoid
 	 * allocating a Buffer just to read the byte length, and memoize the
