feat: implement buffers() for RawSource, OriginalSource, PrefixSource, ReplaceSource, SourceMapSource

claude · claude · commit 64afb00fbb45 · 2026-04-28T15:23:11.000Z
Extend the buffers() API to every concrete Source class so callers always get a Buffer[] without falling back to the abstract Source default. Each single-buffer-backed class returns [this.buffer()]. ReplaceSource delegates to the underlying source's buffers() when no replacements are queued and otherwise materializes the replaced source into a single buffer. https://claude.ai/code/session_01EHhGq9PRFRGefVtwwasCqZ
diff --git a/.changeset/buffers-all-sources.md b/.changeset/buffers-all-sources.md
@@ -0,0 +1,5 @@
+---
+"webpack-sources": patch
+---
+
+Add explicit `buffers()` implementations to `RawSource`, `OriginalSource`, `PrefixSource`, `ReplaceSource`, and `SourceMapSource`. `ReplaceSource` delegates to the underlying source's `buffers()` when no replacements are queued.
diff --git a/lib/OriginalSource.js b/lib/OriginalSource.js
@@ -82,6 +82,13 @@ class OriginalSource extends Source {
 		return this._valueAsBuffer;
 	}
 
+	/**
+	 * @returns {Buffer[]} buffers
+	 */
+	buffers() {
+		return [this.buffer()];
+	}
+
 	/**
 	 * Override Source.prototype.size (= `this.buffer().length`) to avoid
 	 * allocating a Buffer just to read the byte length, and memoize the
diff --git a/lib/PrefixSource.js b/lib/PrefixSource.js
@@ -64,6 +64,13 @@ class PrefixSource extends Source {
 
 	// TODO efficient buffer() implementation
 
+	/**
+	 * @returns {Buffer[]} buffers
+	 */
+	buffers() {
+		return [this.buffer()];
+	}
+
 	/**
 	 * @param {MapOptions=} options map options
 	 * @returns {RawSourceMap | null} map
diff --git a/lib/RawSource.js b/lib/RawSource.js
@@ -93,6 +93,13 @@ class RawSource extends Source {
 		return this._valueAsBuffer;
 	}
 
+	/**
+	 * @returns {Buffer[]} buffers
+	 */
+	buffers() {
+		return [this.buffer()];
+	}
+
 	/**
 	 * Override Source.prototype.size (= `this.buffer().length`) to avoid
 	 * allocating a Buffer just to read the byte length, and memoize the
diff --git a/lib/ReplaceSource.js b/lib/ReplaceSource.js
@@ -178,6 +178,28 @@ class ReplaceSource extends Source {
 		return result.join("");
 	}
 
+	/**
+	 * @returns {Buffer} buffer
+	 */
+	buffer() {
+		if (this._replacements.length === 0) {
+			return this._source.buffer();
+		}
+		return super.buffer();
+	}
+
+	/**
+	 * @returns {Buffer[]} buffers
+	 */
+	buffers() {
+		if (this._replacements.length === 0) {
+			return typeof this._source.buffers === "function"
+				? this._source.buffers()
+				: [this._source.buffer()];
+		}
+		return [this.buffer()];
+	}
+
 	/**
 	 * @param {MapOptions=} options map options
 	 * @returns {RawSourceMap | null} map
diff --git a/lib/SourceMapSource.js b/lib/SourceMapSource.js
@@ -143,6 +143,13 @@ class SourceMapSource extends Source {
 		return this._valueAsBuffer;
 	}
 
+	/**
+	 * @returns {Buffer[]} buffers
+	 */
+	buffers() {
+		return [this.buffer()];
+	}
+
 	/**
 	 * Override Source.prototype.size (= `this.buffer().length`) to avoid
 	 * allocating a Buffer just to read the byte length, and memoize the
diff --git a/test/OriginalSource.js b/test/OriginalSource.js
@@ -107,6 +107,23 @@ describe.each([
 		expect(source.getName()).toBe("file.js");
 	});
 
+	it("should expose buffers() returning a single-entry Buffer[]", () => {
+		const content = "Line1\nLine2\n";
+		const source = new OriginalSource(content, "file.js");
+		const buffers = source.buffers();
+		expect(Array.isArray(buffers)).toBe(true);
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toEqual(Buffer.from(content));
+	});
+
+	it("should reuse the underlying buffer in buffers() when constructed from a Buffer", () => {
+		const buffer = Buffer.from("Line1\nLine2\n");
+		const source = new OriginalSource(buffer, "file.js");
+		const buffers = source.buffers();
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toBe(buffer);
+	});
+
 	it("should compute map correctly from buffer-backed source", () => {
 		const content = "Line1\nLine2\n";
 		const source = new OriginalSource(Buffer.from(content), "file.js");
diff --git a/test/PrefixSource.js b/test/PrefixSource.js
@@ -169,4 +169,13 @@ describe("prefixSource", () => {
 		expect(source.source()).toBe("hello\nworld\n");
 		expect(source.sourceAndMap().source).toBe("hello\nworld\n");
 	});
+
+	it("should expose buffers() returning the prefixed source as a single buffer", () => {
+		const source = new PrefixSource("> ", new RawSource("hello\nworld"));
+		const buffers = source.buffers();
+		expect(Array.isArray(buffers)).toBe(true);
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toEqual(Buffer.from("> hello\n> world"));
+		expect(Buffer.concat(buffers)).toEqual(source.buffer());
+	});
 });
diff --git a/test/RawSource.js b/test/RawSource.js
@@ -166,4 +166,21 @@ describe("rawSource", () => {
 			expect(source.source().toString("utf8")).toEqual(CODE_STRING);
 		});
 	});
+
+	it("should expose buffers() returning a single-entry Buffer[]", () => {
+		const source = new RawSource(CODE_STRING);
+		const buffers = source.buffers();
+		expect(Array.isArray(buffers)).toBe(true);
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toEqual(Buffer.from(CODE_STRING));
+		expect(Buffer.concat(buffers)).toEqual(source.buffer());
+	});
+
+	it("should reuse the underlying buffer in buffers() when constructed from a Buffer", () => {
+		const buffer = Buffer.from(CODE_STRING);
+		const source = new RawSource(buffer);
+		const buffers = source.buffers();
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toBe(buffer);
+	});
 });
diff --git a/test/ReplaceSource.js b/test/ReplaceSource.js
@@ -451,4 +451,23 @@ export default function StaticPage(_ref) {
 		expect(source.source()).toBe("Hello You");
 		expect(source.sourceAndMap()).toHaveProperty("source", "Hello You");
 	});
+
+	it("should expose buffers() reflecting the replaced source", () => {
+		const source = new ReplaceSource(new RawSource("Hello World"));
+		source.replace(6, 10, "You");
+		const buffers = source.buffers();
+		expect(Array.isArray(buffers)).toBe(true);
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toEqual(Buffer.from("Hello You"));
+		expect(Buffer.concat(buffers)).toEqual(source.buffer());
+	});
+
+	it("should delegate buffers() to the underlying source when no replacements", () => {
+		const inner = new RawSource(Buffer.from("untouched"));
+		const source = new ReplaceSource(inner);
+		const buffers = source.buffers();
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toBe(inner.buffer());
+		expect(source.buffer()).toBe(inner.buffer());
+	});
 });
diff --git a/test/SourceMapSource.js b/test/SourceMapSource.js
@@ -578,6 +578,23 @@ describe.each([
 		expect(buffer2).toBe(buffer1);
 	});
 
+	it("should expose buffers() returning a single-entry Buffer[]", () => {
+		const sourceMapSource = new SourceMapSource("source", "name");
+		const buffers = sourceMapSource.buffers();
+		expect(Array.isArray(buffers)).toBe(true);
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toEqual(Buffer.from("source"));
+		expect(Buffer.concat(buffers)).toEqual(sourceMapSource.buffer());
+	});
+
+	it("should reuse the underlying buffer in buffers() when constructed from a Buffer", () => {
+		const buffer = Buffer.from("source", "utf8");
+		const sourceMapSource = new SourceMapSource(buffer, "name");
+		const buffers = sourceMapSource.buffers();
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toBe(buffer);
+	});
+
 	it("should accept source map as string", () => {
 		const mapObj = {
 			version: 3,

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"webpack-sources": patch
 +---
++
 +Add explicit `buffers()` implementations to `RawSource`, `OriginalSource`, `PrefixSource`, `ReplaceSource`, and `SourceMapSource`. `ReplaceSource` delegates to the underlying source's `buffers()` when no replacements are queued.