feat: make Source.buffers() self-contained and benchmark source/buffer/buffers per class

claude · claude · commit 2a016a6c1bdf · 2026-04-28T15:35:47.000Z
- lib/Source.js: buffers() now reads source() directly and wraps a Buffer result without the indirect this.buffer() call. buffer() gains the matching @returns JSDoc. - benchmark: add buffers() cases for RawSource (string, buffer, cached), OriginalSource (string, buffer), PrefixSource, ReplaceSource (no replacements + 1000 small replacements), SourceMapSource (string, buffer), and SizeOnlySource (throws). Existing source()/buffer() cases already cover those methods. - test: add a Source case verifying buffers() returns the buffer directly when source() returns a Buffer. https://claude.ai/code/session_01EHhGq9PRFRGefVtwwasCqZ
diff --git a/benchmark/cases/original-source/index.bench.mjs b/benchmark/cases/original-source/index.bench.mjs
@@ -43,6 +43,18 @@ export default function register(bench) {
 		}
 	});
 
+	bench.add("original-source: buffers() (from string)", () => {
+		for (let i = 0; i < 50; i++) {
+			new sources.OriginalSource(fixtureCode, "fixture.js").buffers();
+		}
+	});
+
+	bench.add("original-source: buffers() (from buffer)", () => {
+		for (let i = 0; i < 50; i++) {
+			new sources.OriginalSource(fixtureBuffer, "fixture.js").buffers();
+		}
+	});
+
 	bench.add("original-source: size()", () => {
 		for (let i = 0; i < 50; i++) {
 			new sources.OriginalSource(fixtureCode, "fixture.js").size();
diff --git a/benchmark/cases/prefix-source/index.bench.mjs b/benchmark/cases/prefix-source/index.bench.mjs
@@ -68,6 +68,14 @@ export default function register(bench) {
 		for (let i = 0; i < 10; i++) ps.buffer();
 	});
 
+	bench.add("prefix-source: buffers()", () => {
+		const ps = new sources.PrefixSource(
+			"\t",
+			new sources.RawSource(fixtureCode),
+		);
+		for (let i = 0; i < 10; i++) ps.buffers();
+	});
+
 	bench.add("prefix-source: size()", () => {
 		const ps = new sources.PrefixSource(
 			"\t",
diff --git a/benchmark/cases/raw-source/index.bench.mjs b/benchmark/cases/raw-source/index.bench.mjs
@@ -43,6 +43,19 @@ export default function register(bench) {
 		for (let i = 0; i < 50; i++) new sources.RawSource(fixtureBuffer).buffer();
 	});
 
+	bench.add("raw-source: buffers() (from string)", () => {
+		for (let i = 0; i < 50; i++) new sources.RawSource(fixtureCode).buffers();
+	});
+
+	bench.add("raw-source: buffers() (from buffer)", () => {
+		for (let i = 0; i < 50; i++) new sources.RawSource(fixtureBuffer).buffers();
+	});
+
+	bench.add("raw-source: buffers() cached", () => {
+		const src = new sources.RawSource(fixtureBuffer);
+		for (let i = 0; i < 500; i++) src.buffers();
+	});
+
 	bench.add("raw-source: size()", () => {
 		for (let i = 0; i < 50; i++) new sources.RawSource(fixtureCode).size();
 	});
diff --git a/benchmark/cases/replace-source/index.bench.mjs b/benchmark/cases/replace-source/index.bench.mjs
@@ -96,6 +96,16 @@ export default function register(bench) {
 		buildManyReplacements(1000).buffer();
 	});
 
+	bench.add("replace-source: buffers() (no replacements)", () => {
+		for (let i = 0; i < 100; i++) {
+			new sources.ReplaceSource(new sources.RawSource(fixtureCode)).buffers();
+		}
+	});
+
+	bench.add("replace-source: buffers() (1000 small replacements)", () => {
+		buildManyReplacements(1000).buffers();
+	});
+
 	bench.add("replace-source: map() (no replacements)", () => {
 		for (let i = 0; i < 10; i++) {
 			new sources.ReplaceSource(
diff --git a/benchmark/cases/size-only-source/index.bench.mjs b/benchmark/cases/size-only-source/index.bench.mjs
@@ -44,6 +44,17 @@ export default function register(bench) {
 		}
 	});
 
+	bench.add("size-only-source: buffers() (throws)", () => {
+		const src = new sources.SizeOnlySource(1024);
+		for (let i = 0; i < 100; i++) {
+			try {
+				src.buffers();
+			} catch {
+				// expected
+			}
+		}
+	});
+
 	bench.add("size-only-source: map() (throws)", () => {
 		const src = new sources.SizeOnlySource(1024);
 		for (let i = 0; i < 100; i++) {
diff --git a/benchmark/cases/source-map-source/index.bench.mjs b/benchmark/cases/source-map-source/index.bench.mjs
@@ -66,6 +66,26 @@ export default function register(bench) {
 		}
 	});
 
+	bench.add("source-map-source: buffers() (from string)", () => {
+		for (let i = 0; i < 50; i++) {
+			new sources.SourceMapSource(
+				fixtureCode,
+				"fixture.js",
+				fixtureMap,
+			).buffers();
+		}
+	});
+
+	bench.add("source-map-source: buffers() (from buffer)", () => {
+		for (let i = 0; i < 50; i++) {
+			new sources.SourceMapSource(
+				fixtureBuffer,
+				"fixture.js",
+				fixtureMap,
+			).buffers();
+		}
+	});
+
 	bench.add("source-map-source: size()", () => {
 		for (let i = 0; i < 50; i++) {
 			new sources.SourceMapSource(fixtureCode, "fixture.js", fixtureMap).size();
diff --git a/lib/Source.js b/lib/Source.js
@@ -46,6 +46,9 @@ class Source {
 		throw new Error("Abstract");
 	}
 
+	/**
+	 * @returns {Buffer} buffer
+	 */
 	buffer() {
 		const source = this.source();
 		if (Buffer.isBuffer(source)) return source;
@@ -56,7 +59,9 @@ class Source {
 	 * @returns {Buffer[]} buffers
 	 */
 	buffers() {
-		return [this.buffer()];
+		const source = this.source();
+		if (Buffer.isBuffer(source)) return [source];
+		return [Buffer.from(source, "utf8")];
 	}
 
 	size() {
diff --git a/test/Source.js b/test/Source.js
@@ -86,4 +86,17 @@ describe("source", () => {
 		expect(buffers).toHaveLength(1);
 		expect(buffers[0]).toEqual(Buffer.from("dummy", "utf8"));
 	});
+
+	it("should return the buffer directly from buffers() when source is a buffer", () => {
+		const buffer = Buffer.from([1, 2, 3]);
+		class DummySource extends Source {
+			source() {
+				return buffer;
+			}
+		}
+		const source = new DummySource();
+		const buffers = source.buffers();
+		expect(buffers).toHaveLength(1);
+		expect(buffers[0]).toBe(buffer);
+	});
 });
