perf: defer _cachedBuffers allocation in CachedSource

claude · claude · commit 21af2e84fc77 · 2026-04-22T17:20:39.000Z
Follow-up to the _cachedSize deferral: PR #204 added a new `this._cachedBuffers = undefined` preallocation to the CachedSource constructor, which re-introduces the same per-construction cost we previously removed from RawSource/OriginalSource/SourceMapSource. `_cachedBuffers` is only read from `buffer()` and `buffers()`, and both call sites already guard with `!== undefined`, which treats missing properties identically to an undefined slot. Drop the eager assignment so every CachedSource construction skips one write and one hidden-class transition, and instances that never call `buffers()` stay on a tighter shape. https://claude.ai/code/session_01LZbaaPrnDTu6y7s4nK4cJz
diff --git a/lib/CachedSource.js b/lib/CachedSource.js
@@ -142,11 +142,6 @@ class CachedSource extends Source {
 		 * @type {Buffer | undefined}
 		 */
 		this._cachedBuffer = cachedData ? cachedData.buffer : undefined;
-		/**
-		 * @private
-		 * @type {Buffer[] | undefined}
-		 */
-		this._cachedBuffers = undefined;
 		/**
 		 * @private
 		 * @type {number | undefined}
