feat: convert source to native ES modules with dual ESM/CJS build#5684
Conversation
…ts and update exports in package.json
|
| Name | Type |
|---|---|
| webpack-dev-server | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5684 +/- ##
==========================================
- Coverage 88.93% 88.90% -0.03%
==========================================
Files 13 13
Lines 5919 5922 +3
==========================================
+ Hits 5264 5265 +1
- Misses 655 657 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| "require": "./dist/Server.js", | ||
| "default": "./lib/Server.js" | ||
| }, | ||
| "./lib/*": "./lib/*", |
There was a problem hiding this comment.
Not sure we should allow lib, it is more internal code
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, let's resolve lib directory and we can merge
) * fix: replace fileURLToPath with require.resolve for client entry points and update exports in package.json * feat: enhance CommonJS support with dual package structure and finalize build script * test: add CommonJS bundle tests for Server class and build pipeline * docs: update changeset * fix: remove unnecessary exports for lib directory in package.json
2 participants
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI