fix: add @types/serve-static to dependencies#4468
Merged
alexander-akait merged 2 commits intoJun 6, 2022
Merged
Conversation
wegry
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
|
|
alexander-akait
previously approved these changes
May 31, 2022
wegry
force-pushed
the
add-types-serve-static-to-deps
branch
from
3f0fe64 to
42313e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
==========================================
- Coverage 92.31% 92.19% -0.13%
==========================================
Files 16 16
Lines 1601 1601
Branches 604 604
==========================================
- Hits 1478 1476 -2
- Misses 112 114 +2
Partials 11 11
Continue to review full report at Codecov.
|
Contributor
Author
|
I tweaked the commit message to try and match standard changelog. |
snitin315
approved these changes
Jun 6, 2022
snitin315
changed the title
@types/serve-static to dependencies
alexander-akait
approved these changes
Jun 6, 2022
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
We should do patch release, pinned, will merge after CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
This change should be covered by the
lint-typesnpm script.Motivation / Use-Case
Fix #4467 with Yarn PnP and Typescript.
Breaking Changes
Additional Info