fix: skip HMR websocket path when forwarding upgrades to user-defined proxies#4316
Conversation
ajhyndman
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
|
|
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Can you add test case and fix types?
Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server. vuejs/vue-cli@72ba750 react/create-react-app#7444
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
==========================================
+ Coverage 83.59% 83.60% +0.01%
==========================================
Files 13 13
Lines 2054 2086 +32
Branches 756 773 +17
==========================================
+ Hits 1717 1744 +27
- Misses 303 306 +3
- Partials 34 36 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjohansebas
changed the title
bjohansebas
requested review from
UlisesGascon and
alexander-akait
and removed request for
anshumanv,
hiroppy,
knagaitsev and
snitin315
|
@bjohansebas can you look at lint and I think we can merge |
|
The linter is failing because some dependencies need to be updated (as usual), so I'm going to merge it anyway. |
|
Fix included in release 5.0.0-0.nightly-2026-06-26-082905 |
|
Fix included in release 4.22.0-0.nightly-2026-06-30-192322 |
|
Fix included in release 4.21.0-0.nightly-2026-07-01-182256 |
|
Fix included in release 4.20.0-0.nightly-2026-07-02-015925 |
4 participants
For Bugs and Features; did you add new tests?
Please let me know what kind of test could be appropriate for this change.
Motivation / Use-Case
Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server.
vuejs/vue-cli@72ba750
react/create-react-app#7444