Skip to content

test: remove duplicate tests#4136

Merged
snitin315 merged 3 commits into
masterfrom
rm-server-tests
Jan 11, 2022
Merged

test: remove duplicate tests#4136
snitin315 merged 3 commits into
masterfrom
rm-server-tests

Conversation

@snitin315

Copy link
Copy Markdown
Member
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

remove duplicate tests.

Breaking Changes

None

Additional Info

No

});
});

it("add hot-only option", (done) => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

});

// TODO: remove this after plugin support is published
it("should create and run server with old parameters order and log deprecation warning", (done) => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test already present.

it(`should work with deprecated API (the order of the arguments in the constructor)`, async () => {

@codecov

codecov Bot commented Dec 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #4136 (6429697) into master (7b8c85b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4136   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          14       14           
  Lines        1540     1540           
  Branches      589      589           
=======================================
  Hits         1421     1421           
  Misses        110      110           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8c85b...6429697. Read the comment docs.

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our CI is now more unstable, we should fix it...

@alexander-akait

Copy link
Copy Markdown
Member

@snitin315 Feel free to merge when CI will green

@snitin315 snitin315 merged commit 415fb66 into master Jan 11, 2022
@snitin315 snitin315 deleted the rm-server-tests branch January 11, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants