Skip to content

fix: drop url package #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexander-akait merged 5 commits into from
Dec 22, 2021
Merged

fix: drop url package #4132

alexander-akait merged 5 commits into from
Dec 22, 2021

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 22, 2021 •
edited
Loading

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Existing tests

Motivation / Use-Case

fixes #4128 fixes #3862

Breaking Changes

No

Additional Info

Format inlined, because we don't need complex logic from url logic, parse dropped, because we need reach else due we because we are throwing exception if currentScript not found, tested for IE11, IE10 should work too

@codecov
Copy link

codecov bot commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #4132 (df0bccc) into master (b0c98f0) will decrease coverage by 0.24%.
The diff coverage is 84.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4132      +/-   ##
==========================================
- Coverage   92.39%   92.15%   -0.25%     
==========================================
  Files          14       14              
  Lines        1513     1543      +30     
  Branches      575      590      +15     
==========================================
+ Hits         1398     1422      +24     
- Misses        107      112       +5     
- Partials        8        9       +1
Impacted Files Coverage Δ
client-src/utils/getCurrentScriptSource.js 100.00% <ø> (ø)
client-src/utils/sendMessage.js 83.33% <ø> (ø)
client-src/utils/createSocketURL.js 88.88% <79.41%> (-11.12%) ⬇️
client-src/clients/SockJSClient.js 100.00% <100.00%> (ø)
client-src/index.js 77.67% <100.00%> (ø)
client-src/utils/parseURL.js 100.00% <100.00%> (+15.78%) ⬆️
client-src/utils/reloadApp.js 78.57% <100.00%> (ø)
lib/Server.js 93.57% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c98f0...df0bccc. Read the comment docs.

@alexander-akait
Copy link
Member Author

alexander-akait commented Dec 22, 2021

@snitin315 Added some types for client-src, but we should finish it

@snitin315
Copy link
Member

snitin315 commented Dec 22, 2021

@snitin315 Added some types for client-src, but we should finish it

I will look what's remaining and add more types.

@alexander-akait alexander-akait merged commit 4e5d8ea into master Dec 22, 2021
@alexander-akait alexander-akait deleted the fix-drop-url branch December 22, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anshumanv anshumanv Awaiting requested review from anshumanv

@hiroppy hiroppy Awaiting requested review from hiroppy

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

@snitin315 snitin315 Awaiting requested review from snitin315

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

With futureDefaults: true, webpack-dev-server warns about own dependency querystring dependency is deprecated

3 participants

@alexander-akait @snitin315