Skip to content

test: add snapshots for page errors#3835

Merged
snitin315 merged 1 commit into
masterfrom
test/page-errors-sanp
Sep 12, 2021
Merged

test: add snapshots for page errors#3835
snitin315 merged 1 commit into
masterfrom
test/page-errors-sanp

Conversation

@snitin315

Copy link
Copy Markdown
Member
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Added more assertions.

Motivation / Use-Case

Add snapshots for page errors like the rest of the tests.

Breaking Changes

None

Additional Info

No

@codecov

codecov Bot commented Sep 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3835 (18ddefc) into master (8cc4e1b) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3835      +/-   ##
==========================================
- Coverage   92.81%   92.67%   -0.15%     
==========================================
  Files          14       14              
  Lines        1337     1337              
  Branches      472      472              
==========================================
- Hits         1241     1239       -2     
- Misses         88       90       +2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc4e1b...18ddefc. Read the comment docs.

@snitin315 snitin315 merged commit cf330f4 into master Sep 12, 2021
@snitin315 snitin315 deleted the test/page-errors-sanp branch September 12, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant