Skip to content

Conversation

@snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Already present, CI should be green.

Motivation / Use-Case

webpack-cli already defines --hot, so it is kind of just duplicate code.

Also right now it shows --hot two times because of this in suggestions on passing a wrong cli option.

Before

Screenshot 2021-07-12 at 5 35 42 PM

After

Screenshot 2021-07-12 at 5 35 51 PM

Breaking Changes

None

Additional Info

No

@snitin315 snitin315 marked this pull request as draft July 12, 2021 12:11
@alexander-akait
Copy link
Member

here interesting case, I think we should solve it on webpack-cli level, here #3522, for webpack-dev-server we support the hot option, but webpack-cli should merge them

@snitin315
Copy link
Member Author

It looks like we may need it here, and should update code in webpack-cli to not show --hot multiple times.

@alexander-akait
Copy link
Member

Yep, I think we should fix it in webpack-cli

@snitin315
Copy link
Member Author

hmm, will fix it 👍🏻

@alexander-akait
Copy link
Member

To be honestly I think we remove --hot from webpack-cli, for developers who want to use hot module replacement for non browser env should add plugin manually

@snitin315
Copy link
Member Author

I think the same, let's remove from cli

@alexander-akait
Copy link
Member

Yep, I think we can start to create the next branch in webpack-cli and start to working, drop webpack v4, drop node v10 and some other stuff, feel free to start and I will add small readmap (there are no a lot of work in webpack-cli for the next major release)

@snitin315
Copy link
Member Author

Will do 👍

@alexander-akait
Copy link
Member

@snitin315 Let's close here, it will be for webpack-cli@next

@snitin315
Copy link
Member Author

Yep we can close.

@snitin315 snitin315 closed this Jul 19, 2021
@snitin315 snitin315 deleted the exclude-hot branch July 19, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants