-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: exlcude hot for cli
#3522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
here interesting case, I think we should solve it on webpack-cli level, here #3522, for webpack-dev-server we support the |
|
It looks like we may need it here, and should update code in webpack-cli to not show |
|
Yep, I think we should fix it in webpack-cli |
|
hmm, will fix it 👍🏻 |
|
To be honestly I think we remove |
|
I think the same, let's remove from cli |
|
Yep, I think we can start to create the next branch in webpack-cli and start to working, drop webpack v4, drop node v10 and some other stuff, feel free to start and I will add small readmap (there are no a lot of work in webpack-cli for the next major release) |
|
Will do 👍 |
|
@snitin315 Let's close here, it will be for webpack-cli@next |
|
Yep we can close. |
For Bugs and Features; did you add new tests?
Already present, CI should be green.
Motivation / Use-Case
webpack-clialready defines--hot, so it is kind of just duplicate code.Also right now it shows
--hottwo times because of this in suggestions on passing a wrong cli option.Before
After
Breaking Changes
None
Additional Info
No