fix: polling usage in watchFiles option#3366
Merged
Merged
Conversation
anshumanv
requested review from
alexander-akait,
hiroppy,
knagaitsev and
snitin315
as code owners
Contributor
Author
|
Not sure how to test this, maybe mock chokidar and check it's getting called by the correct config? |
Member
Yep, right direction |
Codecov Report
@@ Coverage Diff @@
## master #3366 +/- ##
==========================================
+ Coverage 95.67% 95.76% +0.09%
==========================================
Files 33 33
Lines 1295 1299 +4
Branches 377 381 +4
==========================================
+ Hits 1239 1244 +5
+ Misses 52 51 -1
Partials 4 4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yet to
Motivation / Use-Case
Fix #3365
Breaking Changes
no
Additional Info