Skip to content

fix(config): enable --overlay#1968

Merged
hiroppy merged 1 commit into
masterfrom
feature/fix-overlay
Jun 4, 2019
Merged

fix(config): enable --overlay#1968
hiroppy merged 1 commit into
masterfrom
feature/fix-overlay

Conversation

@hiroppy

@hiroppy hiroppy commented Jun 4, 2019

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Currently, --overlay is not working at master branch. Please try to run examples/cli/overlay.

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 4, 2019 20:45
@alexander-akait

alexander-akait commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Is it regression?

@hiroppy

hiroppy commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yes. We were not aware of this bug. FYI: https://github.com/webpack/webpack-dev-server/tree/master/examples/cli/overlay

@alexander-akait

alexander-akait commented Jun 4, 2019

Copy link
Copy Markdown
Member

Feel free to merge after CI green

@codecov

codecov Bot commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1968 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   92.55%   92.47%   -0.08%     
==========================================
  Files          28       28              
  Lines        1075     1077       +2     
  Branches      321      322       +1     
==========================================
+ Hits          995      996       +1     
- Misses         76       77       +1     
  Partials        4        4
Impacted Files Coverage Δ
lib/utils/createConfig.js 91.81% <50%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0783a4a...0b5d972. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1968 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   92.55%   92.47%   -0.08%     
==========================================
  Files          28       28              
  Lines        1075     1077       +2     
  Branches      321      322       +1     
==========================================
+ Hits          995      996       +1     
- Misses         76       77       +1     
  Partials        4        4
Impacted Files Coverage Δ
lib/utils/createConfig.js 91.81% <50%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0783a4a...0b5d972. Read the comment docs.

@hiroppy hiroppy changed the title fix(cofnig): enable overlay fix(config): enable --overlay Jun 4, 2019
@hiroppy hiroppy merged commit dc81e23 into master Jun 4, 2019
@hiroppy hiroppy deleted the feature/fix-overlay branch June 4, 2019 21:27
@snyk-bot snyk-bot mentioned this pull request Aug 30, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 1, 2019
Open
This was referenced Dec 14, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroppy @alexander-akait