Skip to content

test(client): add tests for default/index.js#1957

Merged
alexander-akait merged 1 commit into
masterfrom
feature/add-index-test
Jun 4, 2019
Merged

test(client): add tests for default/index.js#1957
alexander-akait merged 1 commit into
masterfrom
feature/add-index-test

Conversation

@hiroppy

@hiroppy hiroppy commented Jun 3, 2019

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yep

Motivation / Use-Case

Absolutely necessary these😁

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 3, 2019 23:47
@codecov

codecov Bot commented Jun 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1957 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
- Coverage   92.58%   92.55%   -0.04%     
==========================================
  Files          27       28       +1     
  Lines         985     1075      +90     
  Branches      307      321      +14     
==========================================
+ Hits          912      995      +83     
- Misses         70       76       +6     
- Partials        3        4       +1
Impacted Files Coverage Δ
client-src/default/index.js 92.22% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d346a53...d55ba25. Read the comment docs.

@hiroppy hiroppy force-pushed the feature/add-index-test branch from d6af966 to c8b1da9 Compare June 4, 2019 00:03
@hiroppy hiroppy force-pushed the feature/add-index-test branch from cad9ee7 to d55ba25 Compare June 4, 2019 00:08

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@alexander-akait alexander-akait merged commit 79325e5 into master Jun 4, 2019
@alexander-akait alexander-akait deleted the feature/add-index-test branch June 4, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants