Skip to content

test(server): add SockJSServer test#1956

Merged
hiroppy merged 2 commits into
webpack:masterfrom
knagaitsev:sockjs-server-test
Jun 3, 2019
Merged

test(server): add SockJSServer test#1956
hiroppy merged 2 commits into
webpack:masterfrom
knagaitsev:sockjs-server-test

Conversation

@knagaitsev

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

New test.

Motivation / Use-Case

Tests the recently added SockJSServer

Breaking Changes

None

Additional Info

Comment thread test/SockJSServer.test.js Outdated
});

afterAll((done) => {
listeningApp.close(() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listeningApp.close(done);

@knagaitsev knagaitsev force-pushed the sockjs-server-test branch from 3566c42 to 0f37c40 Compare June 3, 2019 17:24
@hiroppy hiroppy merged commit d346a53 into webpack:master Jun 3, 2019
@knagaitsev knagaitsev added gsoc Google Summer of Code scope: ws(s) labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsoc Google Summer of Code scope: ws(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants