Skip to content

refactor(client): create createSocketUrl module into utils#1954

Merged
alexander-akait merged 1 commit into
masterfrom
feature/refactor-create-socket-url
Jun 3, 2019
Merged

refactor(client): create createSocketUrl module into utils#1954
alexander-akait merged 1 commit into
masterfrom
feature/refactor-create-socket-url

Conversation

@hiroppy

@hiroppy hiroppy commented Jun 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

refactoring, yep

Motivation / Use-Case

refactoring client code

Breaking Changes

no

Additional Info

Perhaps existing code seems to have bugs in some patterns. (or my sample URLs are bad😉) See the result of snapshots. Let's fix it with other PR.

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 2, 2019 15:44
@codecov

codecov Bot commented Jun 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1954 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1954      +/-   ##
==========================================
+ Coverage   91.91%   92.19%   +0.27%     
==========================================
  Files          23       24       +1     
  Lines         903      935      +32     
  Branches      283      297      +14     
==========================================
+ Hits          830      862      +32     
  Misses         70       70              
  Partials        3        3
Impacted Files Coverage Δ
client-src/default/utils/createSocketUrl.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1ad89...6978c28. Read the comment docs.

@hiroppy

hiroppy commented Jun 2, 2019

Copy link
Copy Markdown
Contributor Author

Node6 has errors about the file protocol.

sample: file://filename
node6: file:/sockjs-node
other: file:///sockjs-node

sample: file:///etc/file
node6: file:/sockjs-node
other: file:///sockjs-node

@alexander-akait

alexander-akait commented Jun 3, 2019

Copy link
Copy Markdown
Member

Let's comment file right now and add TODO about enable this for next major release

@hiroppy hiroppy force-pushed the feature/refactor-create-socket-url branch from d9cb8cf to 6978c28 Compare June 3, 2019 14:56
@hiroppy

hiroppy commented Jun 3, 2019

Copy link
Copy Markdown
Contributor Author

@evilebottnawi PTAL

@alexander-akait alexander-akait merged commit 1581adc into master Jun 3, 2019
@alexander-akait alexander-akait deleted the feature/refactor-create-socket-url branch June 3, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroppy @alexander-akait