Skip to content

refactor(client): create log module into utils#1953

Merged
alexander-akait merged 3 commits into
masterfrom
feature/refactor-client-log
Jun 3, 2019
Merged

refactor(client): create log module into utils#1953
alexander-akait merged 3 commits into
masterfrom
feature/refactor-client-log

Conversation

@hiroppy

@hiroppy hiroppy commented Jun 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

refactoring

Motivation / Use-Case

refactoring client code

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 2, 2019 08:17
@hiroppy hiroppy force-pushed the feature/refactor-client-log branch from 99594bc to 018f3d5 Compare June 2, 2019 08:18
@hiroppy

This comment has been minimized.

Sign in to view
@codecov

codecov Bot commented Jun 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1953 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
+ Coverage   91.91%   92.16%   +0.25%     
==========================================
  Files          23       24       +1     
  Lines         903      932      +29     
  Branches      283      293      +10     
==========================================
+ Hits          830      859      +29     
  Misses         70       70              
  Partials        3        3
Impacted Files Coverage Δ
client-src/default/utils/log.js 100% <100%> (ø)
client-src/default/utils/reloadApp.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1ad89...472a0bf. Read the comment docs.

@hiroppy hiroppy force-pushed the feature/refactor-client-log branch 2 times, most recently from e7d4837 to 712b6b2 Compare June 2, 2019 19:49
@hiroppy

This comment has been minimized.

Sign in to view
alexander-akait
alexander-akait previously approved these changes Jun 3, 2019
View reviewed changes

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@alexander-akait

alexander-akait commented Jun 3, 2019

Copy link
Copy Markdown
Member

/cc @hiroppy need rebase

anshumanv
anshumanv previously approved these changes Jun 3, 2019
View reviewed changes

@anshumanv anshumanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor ✨

@hiroppy hiroppy dismissed stale reviews from anshumanv and alexander-akait via 447f57b June 3, 2019 14:44
@hiroppy hiroppy force-pushed the feature/refactor-client-log branch from 712b6b2 to 447f57b Compare June 3, 2019 14:44
@hiroppy hiroppy force-pushed the feature/refactor-client-log branch from 447f57b to 472a0bf Compare June 3, 2019 15:00
@hiroppy

hiroppy commented Jun 3, 2019

Copy link
Copy Markdown
Contributor Author

@evilebottnawi PTAL

@codecov

codecov Bot commented Jun 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1953 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
+ Coverage   91.91%   92.16%   +0.25%     
==========================================
  Files          23       24       +1     
  Lines         903      932      +29     
  Branches      283      293      +10     
==========================================
+ Hits          830      859      +29     
  Misses         70       70              
  Partials        3        3
Impacted Files Coverage Δ
client-src/default/utils/log.js 100% <100%> (ø)
client-src/default/utils/reloadApp.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1ad89...472a0bf. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1953 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
+ Coverage   91.91%   92.16%   +0.25%     
==========================================
  Files          23       24       +1     
  Lines         903      932      +29     
  Branches      283      293      +10     
==========================================
+ Hits          830      859      +29     
  Misses         70       70              
  Partials        3        3
Impacted Files Coverage Δ
client-src/default/utils/log.js 100% <100%> (ø)
client-src/default/utils/reloadApp.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1ad89...472a0bf. Read the comment docs.

@codecov-io

codecov-io commented Jun 3, 2019 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1953 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
+ Coverage   92.19%   92.42%   +0.23%     
==========================================
  Files          24       25       +1     
  Lines         935      964      +29     
  Branches      297      307      +10     
==========================================
+ Hits          862      891      +29     
  Misses         70       70              
  Partials        3        3
Impacted Files Coverage Δ
client-src/default/utils/log.js 100% <100%> (ø)
client-src/default/utils/reloadApp.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1581adc...b0bf8c8. Read the comment docs.

@alexander-akait

alexander-akait commented Jun 3, 2019

Copy link
Copy Markdown
Member

/cc @hiroppy need fix lint problem

@hiroppy

hiroppy commented Jun 3, 2019

Copy link
Copy Markdown
Contributor Author

fixed

@alexander-akait alexander-akait merged commit 6973e4c into master Jun 3, 2019
@alexander-akait alexander-akait deleted the feature/refactor-client-log branch June 3, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait left review comments
+1 more reviewer
@anshumanv anshumanv anshumanv left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hiroppy @alexander-akait @codecov-io @anshumanv @evilebottnawi