test(routes): stop checking for res.text#1952
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1952 +/- ##
======================================
Coverage 91.8% 91.8%
======================================
Files 23 23
Lines 903 903
Branches 283 283
======================================
Hits 829 829
Misses 71 71
Partials 3 3Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
nope, updated
Motivation / Use-Case
I want to get rid of source code snapshots because a person who submits a pr might make a mistake. e.g. build using the old code and update the snapshot. But it is difficult to check at the review. (of course, CI will tell us)
I want to avoid testing being dependent on the built file of user's local. Also, clients are changing frequently.
Breaking Changes
no
Additional Info