refactor: utils and server#1943
Merged
alexander-akait merged 2 commits intoJun 1, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
+ Coverage 91.5% 91.54% +0.04%
==========================================
Files 18 19 +1
Lines 836 840 +4
Branches 263 263
==========================================
+ Hits 765 769 +4
Misses 68 68
Partials 3 3
Continue to review full report at Codecov.
|
hiroppy
suggested changes
May 31, 2019
|
|
||
| const open = require('opn'); | ||
|
|
||
| function runBonjour(uri, options, log) { |
Contributor
There was a problem hiding this comment.
runBonjour should be renamed.
alexander-akait
force-pushed
the
refactor-webpack-dev-server-utils-and-code
branch
from
2db47c3 to
7f620d6
Compare
Member
Author
|
/cc @hiroppy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no need
Motivation / Use-Case
move
opnlogin to own util likebonjourWe should move
opnlogic fromstatusutil because it is misleading status should only output logs (based on name of util), so let's do it in next prBreaking Changes
No
Additional Info
No