add options test#1821
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
=======================================
Coverage 87.66% 87.66%
=======================================
Files 9 9
Lines 608 608
Branches 185 185
=======================================
Hits 533 533
Misses 63 63
Partials 12 12Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
I want to avoid forgetting to add an
errorMessagewhen we add a property.I added snapshots because #1819 has a big refactoring of options.json but I don' think they are not necessary. Maybe, I'll delete them after merging of #1819.
Breaking Changes
Additional Info
We should add documents about
sockPort,injectClientandinjectHot.