Only add entries after compilers have been created#1774
Merged
alexander-akait merged 2 commits intoApr 9, 2019
Merged
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 9 9
Lines 593 593
Branches 177 177
=======================================
Hits 520 520
Misses 61 61
Partials 12 12Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Apr 9, 2019
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Yep, looks we forget about remove this line, we need tests. We have regression after release 3.3.0 so i do release today, If you have time to add tests it will be good, otherwise I will write them myself
hiroppy
approved these changes
Apr 9, 2019
Contributor
|
/cc @evilebottnawi added tests |
Contributor
|
Oops, I'll fix |
hiroppy
force-pushed
the
only-add-entries-after-compiler-created
branch
from
9db03d8 to
468e45f
Compare
Member
|
/cc @hiroppy need rebase 😞 |
hiroppy
force-pushed
the
only-add-entries-after-compiler-created
branch
from
468e45f to
4bf5d96
Compare
Contributor
|
@evilebottnawi PTAL;) |
alexander-akait
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No...
Motivation / Use-Case
Currently
addEntriesis called twice when using thecli. First it is called here in the cli bin, and then always called again when we create the dev server instance by calling updateCompiler then here.This extra call is not needed, and actually causes an issue with my specific setup. In my Webpack config the
entryis set dynamically via a plugin once the plugin has initialized. Since the first call toaddEntriesis ran on the raw config before any plugins run it is inaccurate and thinks that I have no entries, causing some issues. This would cause issues for any plugin which mutates the entries assuming it is used with thewebpack-dev-servercli.Additional Info
If a test case is required for this then I'd be happy to work with someone to figure out the best way to integrate such a test into this suite. It looks like the CLI tests are fairly basic and separated from the server tests.