fix(Server): validate express.static.mime.types #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
force-pushed
the
feature/fix-server
branch
from
9e1ea37 to
4e5af29
Compare
lib/Server.js
Outdated
| express.static && | ||
| express.static.mime && | ||
| express.static.mime.types && | ||
| !express.static.mime.types.wasm |
Member
There was a problem hiding this comment.
I think better to remove !express.static.mime.types.wasm because in some old cases it can be text/html and it is invalid, we need use right mime for wasm
hiroppy
force-pushed
the
feature/fix-server
branch
from
4e5af29 to
1cdb254
Compare
Codecov Report
@@ Coverage Diff @@
## master #1765 +/- ##
==========================================
+ Coverage 87.6% 87.62% +0.02%
==========================================
Files 9 9
Lines 589 590 +1
Branches 175 176 +1
==========================================
+ Hits 516 517 +1
Misses 61 61
Partials 12 12
Continue to review full report at Codecov.
|
Member
Author
|
@evilebottnawi PTAL 🙏 |
Member
|
/cc @hiroppy something wrong with linting |
hiroppy
force-pushed
the
feature/fix-server
branch
from
1cdb254 to
2d0a572
Compare
Member
Author
|
Fixed. |
Member
|
God job! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1724
For Bugs and Features; did you add new tests?
Yes.
A test which Checks
application/wasmalready exists.https://github.com/webpack/webpack-dev-server/blob/master/test/ContentBase.test.js#L301
Motivation / Use-Case
Validate express object.
Breaking Changes
no
Additional Info
no