/cc @hiroppy We need setup curly in eslint to avoid mixed style with and without brackets

Which do you prefer modifying webpack-dev-server's eslint config or eslint-config-webpack?

@hiroppy eslint-config-webpack https://github.com/webpack-contrib/eslint-config-webpack

Codecov Report

Merging #1760 into master will increase coverage by 0.69%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1760      +/-   ##
==========================================
+ Coverage   86.85%   87.54%   +0.69%     
==========================================
  Files           9        9              
  Lines         578      578              
  Branches      170      170              
==========================================
+ Hits          502      506       +4     
+ Misses         63       60       -3     
+ Partials       13       12       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31dfe22...cf2aeae. Read the comment docs.

@evilebottnawi eslint-config-prettier overwrite this rule.

I found that eslint-config-prettier was overriding the rules.(curly: off)

So, we have to change the order https://github.com/webpack/webpack-dev-server/blob/master/.eslintrc#L2 or write this rule to webpack-dev-server's eslintrc.

hm, it is strange, need investigate why prettier disable curly, because prettier don't add { and }

eslint-config-prettier sets 0. 😞

https://github.com/prettier/eslint-config-prettier/blob/dd8511b107e5adaaa107a2f8d83d9298018e895b/index.js#L9

@hiroppy https://github.com/prettier/eslint-config-prettier/blob/dd8511b107e5adaaa107a2f8d83d9298018e895b/README.md#curly, we need change order, yep

Yeah, but we are setting "extends": ["webpack", "prettier"] now, so the setting of eslint-config-webpack is overwritten because the setting of curly is written in eslint-config-prettier.

@hiroppy we need fix 👍

@evilebottnawi for now, I created #1761.