fix: allow ca, key and cert will be string (regression)#1676
Merged
alexander-akait merged 1 commit intomasterfrom Feb 21, 2019
Merged
fix: allow ca, key and cert will be string (regression)#1676alexander-akait merged 1 commit intomasterfrom
ca, key and cert will be string (regression)#1676alexander-akait merged 1 commit intomasterfrom
Conversation
2 tasks
alexander-akait
commented
Feb 21, 2019
|
|
||
| fs.writeFileSync(certPath, pems.private + pems.cert, { | ||
| encoding: 'utf-8', | ||
| encoding: 'utf8', |
Member
Author
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #1676 +/- ##
==========================================
+ Coverage 75.12% 76.17% +1.04%
==========================================
Files 17 17
Lines 591 596 +5
Branches 172 173 +1
==========================================
+ Hits 444 454 +10
+ Misses 113 108 -5
Partials 34 34
Continue to review full report at Codecov.
|
alan-agius4
reviewed
Feb 21, 2019
|
|
||
| if (stats) { | ||
| // It is file | ||
| options.https[property] = fs.readFileSync(path.resolve(value)); |
Contributor
There was a problem hiding this comment.
Shouldn’t this have utf8 encoding as well?
Member
Author
There was a problem hiding this comment.
@alan-agius4 hm, maybe, can you provide example?
Member
Author
There was a problem hiding this comment.
buffer.toString :
encoding <string> The character encoding to use. Default: 'utf8'.
buf.toString([encoding[, start[, end]]])
Member
Author
There was a problem hiding this comment.
So default is utf8
Member
Author
|
/cc @hiroppy need review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
fixes #1674
Breaking Changes
No
Additional Info
It is regression, just not
pfxcan't be string due it is binary format