chore(deps): update#1671
Merged
Merged
Conversation
alexander-akait
commented
Feb 19, 2019
| } | ||
| // if (shouldSkipTestSuite()) { | ||
| // return; | ||
| // } |
Member
Author
There was a problem hiding this comment.
Let's see on issue status with updated http-proxy-middleware
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
@evilebottnawi no 😄 #1672 we don't run npm test
Contributor
|
wait for #1672 |
Codecov Report
@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
- Coverage 75.45% 75.12% -0.34%
==========================================
Files 19 17 -2
Lines 599 591 -8
Branches 173 172 -1
==========================================
- Hits 452 444 -8
Misses 113 113
Partials 34 34
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
chore-update-deps
branch
from
bdc3555 to
13d2445
Compare
Member
Author
|
Problems with proxy solved 👍 Feel free to feedback |
Member
Author
|
/cc @hiroppy Can you help with #1671 (comment) (look bootom)? Thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
update deps
Breaking Changes
Should be no
Additional Info
No
/cc @hiroppy
What we need to do in next PRs:
ConcurrentCompilationError: You ran Webpack twice. Each instance only supports a single concurrent compilation at a time.errors in tests.skiptest inCompress.test.jsCan you take care?