style: allow comma-dangle in eslintrc because compete with prettier#1649
Merged
Conversation
hiroppy
requested review from
alexander-akait and
michael-ciniawsky
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
+ Coverage 75.14% 75.29% +0.14%
==========================================
Files 10 10
Lines 688 688
==========================================
+ Hits 517 518 +1
+ Misses 171 170 -1
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Feb 5, 2019
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Thanks, my carelessness 😞
Member
|
@hiroppy what about migrate on jest? |
Contributor
Author
|
np, thanks for your review! yep, I agree with you. I'll migrate to jest from mocha:) |
Member
|
@hiroppy thanks for helping 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Related to #1647 (comment)
Breaking Changes
Additional Info