introduce prettier#1647
Conversation
hiroppy
requested review from
alexander-akait and
michael-ciniawsky
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
+ Coverage 75.1% 75.29% +0.18%
==========================================
Files 10 10
Lines 687 688 +1
==========================================
+ Hits 516 518 +2
+ Misses 171 170 -1
Continue to review full report at Codecov.
|
|
Code should have same tab/space width, that is current style. |
| } | ||
| } | ||
| ] | ||
| }; |
There was a problem hiding this comment.
Use this config:
{
"singleQuote": true,
"trailingComma": "es5",
"arrowParens": "always"
}
There was a problem hiding this comment.
There was a problem hiding this comment.
@evenstensberg I made a forced push to add html to prettier.
There was a problem hiding this comment.
Looks like a regular config, got no opinion here. @evilebottnawi has worked with this more to have a better argument
There was a problem hiding this comment.
@evenstensberg Oops, Sorry, I mistook the name of the destination 🙇
|
@evilebottnawi sorry but do you want spaces or tabs? I’m fine either way! |
|
@hiroppy spaces |
|
@evilebottnawi I changed spaces from tabs:) |
| ></script> | ||
| </head> | ||
| <body></body> | ||
| </html> |
There was a problem hiding this comment.
Let's don't use prettier here
|
@evilebottnawi I removed |
4 participants
For Bugs and Features; did you add new tests?
Motivation / Use-Case
I would like to introduce
prettierfor development.And I picked configure file and command from webpack repository.
Breaking Changes
Additional Info
Currently, the webpack-dev-server code is far out of webpack's rule and there are many changes in this PR.
So should we decide on a custom rule? /cc @evilebottnawi