Codecov Report

Merging #1498 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files          10       10           
  Lines         666      666           
=======================================
  Hits          493      493           
  Misses        173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d37cc5...0cb8ab3. Read the comment docs.

Please use e.g del-cli or rimraf instead and remove this file

"prepare: "del-cli ssl/*.pem && ..."
- "prepare:delete-certs: ..."

@michael-ciniawsky: done and done. Although I have no objection to the requested changes (and implemented as requested) the original decision to create a custom delete with a standalone rule was

• to avoid pulling a dependency for something as trivial as removing some files from a folder
• to allow for the certificates to be removed from the folder even when prepare is not called directly.

to avoid pulling a dependency for something as trivial as removing some files from a folder

While e.g rimraf may contain slightly more code, it fits the use case (cross-platform rm), is tested and clearly separates itself from the rest of the code base (e.g delete-certs.js wouldn't have belonged into lib, since it's a build helper). Size doesn't really matter here since this module doesn't run in e.g the browser

to allow for the certificates to be removed from the folder even when prepare is not called directly.

You could propose a clean script and refactored it out of prepare, if it has a concrete benefit/use case. But please open a separate PR for this

@ferdinando-ferreira Please sign the CLA

@michael-ciniawsky:

licence/cla Expected — Waiting for status to be reported

I believe I have to wait until the cla system somehow update it's status. Maybe something related to cla-assistant/cla-assistant#124?

@michael-ciniawsky: licence/cla stuck at

Expected — Waiting for status to be reported

May be related to cla-assistant/cla-assistant#303 and cla-assistant/cla-assistant#124, should I do something?