style(utils/addEntries): cleaner variable naming#1478
Conversation
| const domain = createDomain(devServerOptions, app); | ||
| const devClient = [`${require.resolve('../../client/')}?${domain}`]; | ||
| const domain = createDomain(options, app); | ||
| const entries = [ `${require.resolve('../../client/')}?${domain}` ]; |
There was a problem hiding this comment.
Looks your have here, maybe better run prettier?
There was a problem hiding this comment.
The space is intenentional [ a, b ] here, prettier does hopefully leave it :)
There was a problem hiding this comment.
@michael-ciniawsky hm, we should integrate prettier here 😕
There was a problem hiding this comment.
Yep, prettier will be included with webpack-defaults in webpack-dev-server >= v4.0.0, it should still leave whitespace in this case since it is more readable
|
@michael-ciniawsky looks appveyor fail maybe need rebase? |
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
+ Coverage 74.02% 74.17% +0.15%
==========================================
Files 10 10
Lines 666 666
==========================================
+ Hits 493 494 +1
+ Misses 173 172 -1
Continue to review full report at Codecov.
|
|
Yep :) |
michael-ciniawsky
added
status: approved
and removed
pr: review
severity: 4 (inconvenient)
labels
2 participants
Type
Issues
SemVer