refactor(bin): move options and helpers into separate files#1470
Merged
Conversation
michael-ciniawsky
force-pushed
the
refactor/bin
branch
from
a2dfec1 to
65e98da
Compare
Codecov Report
@@ Coverage Diff @@
## master #1470 +/- ##
==========================================
- Coverage 75.55% 72.72% -2.83%
==========================================
Files 8 10 +2
Lines 679 726 +47
==========================================
+ Hits 513 528 +15
- Misses 166 198 +32
Continue to review full report at Codecov.
|
michael-ciniawsky
force-pushed
the
refactor/bin
branch
from
65e98da to
8d88522
Compare
alexander-akait
approved these changes
Aug 27, 2018
alexander-akait
requested changes
Aug 27, 2018
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Looks windows tests broken 😞 We need fix their.
michael-ciniawsky
force-pushed
the
refactor/bin
branch
from
8d88522 to
1a3744c
Compare
michael-ciniawsky
force-pushed
the
refactor/bin
branch
from
1a3744c to
9b016ae
Compare
michael-ciniawsky
added
status: approved
and removed
pr: review
priority: 3 (important)
severity: 4 (inconvenient)
labels
Contributor
Author
|
AppVeyor failures are expected atm, since there is no setup yet (appveyor.yml) yet (#1468) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Issues
SemVer