Skip to content

refactor(lib/utils): move createLog && rename files#1465

Merged
michael-ciniawsky merged 1 commit into
masterfrom
refactor/lib/utils
Aug 27, 2018
Merged

refactor(lib/utils): move createLog && rename files#1465
michael-ciniawsky merged 1 commit into
masterfrom
refactor/lib/utils

Conversation

@michael-ciniawsky

Copy link
Copy Markdown
Contributor

Type

  • Refactor

Issues

  • None

SemVer

  • Patch

@codecov

codecov Bot commented Aug 24, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1465 into master will decrease coverage by 0.06%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   78.94%   78.88%   -0.07%     
==========================================
  Files           5        5              
  Lines         494      502       +8     
  Branches      161      164       +3     
==========================================
+ Hits          390      396       +6     
- Misses        104      106       +2
Impacted Files Coverage Δ
lib/utils/addEntries.js 100% <100%> (ø)
lib/Server.js 81.92% <100%> (ø) ⬆️
lib/utils/createDomain.js 87.5% <87.5%> (ø)
lib/utils/createLogger.js 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2220c4...1a7f77d. Read the comment docs.

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@michael-ciniawsky

Copy link
Copy Markdown
Contributor Author

AppVeyor failures are expected atm, since there is no setup yet (appveyor.yml) yet (#1468)

@codecov

codecov Bot commented Aug 27, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1465 into master will decrease coverage by 0.03%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   75.58%   75.55%   -0.04%     
==========================================
  Files           8        8              
  Lines         680      679       -1     
==========================================
- Hits          514      513       -1     
  Misses        166      166
Impacted Files Coverage Δ
lib/Server.js 83.43% <100%> (ø) ⬆️
lib/utils/addEntries.js 100% <100%> (ø)
lib/utils/createDomain.js 100% <100%> (ø)
bin/webpack-dev-server.js 62.63% <100%> (ø) ⬆️
lib/utils/createLogger.js 87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1f0c1...c4e0073. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants