chore: update http-proxy-middleware to version 4.1.1 and add tests for pathRewrite functionality

bjohansebas · bjohansebas · commit f113b00811d3 · 2026-06-22T20:18:20.000-05:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "connect-history-api-fallback": "^2.0.0",
     "express": "^5.2.1",
     "graceful-fs": "^4.2.11",
-    "http-proxy-middleware": "^4.0.0",
+    "http-proxy-middleware": "^4.1.1",
     "ipaddr.js": "^2.3.0",
     "launch-editor": "^2.13.2",
     "open": "^11.0.0",
diff --git a/test/server/proxy-option.test.js b/test/server/proxy-option.test.js
@@ -33,6 +33,29 @@ const proxyOptionPathsAsProperties = [
     pathRewrite: () => "/index.html",
     router: () => `http://localhost:${port3}`,
   },
+  {
+    context: "/send-data",
+    target: `http://localhost:${port1}`,
+    pathRewrite: (path, req, res) => {
+      res.end("data sent from pathRewrite");
+
+      return path;
+    },
+  },
+  {
+    context: "/async-send-data",
+    target: `http://localhost:${port1}`,
+    pathRewrite: async (path, req, res) => {
+      await new Promise((resolve) => {
+        setTimeout(() => {
+          res.end("async data sent from pathRewrite");
+          resolve();
+        }, 10);
+      });
+
+      return path;
+    },
+  },
 ];
 
 const proxyOption = [
@@ -252,6 +275,20 @@ describe("proxy option", () => {
         expect(response.status).toBe(200);
         expect(response.text).toContain("Hello");
       });
+
+      it("should allow sending a response directly from pathRewrite", async () => {
+        const response = await req.get("/send-data");
+
+        expect(response.status).toBe(200);
+        expect(response.text).toBe("data sent from pathRewrite");
+      });
+
+      it("should wait for an async pathRewrite that sends a response", async () => {
+        const response = await req.get("/async-send-data");
+
+        expect(response.status).toBe(200);
+        expect(response.text).toBe("async data sent from pathRewrite");
+      });
     });
   });
 
