refactor: code

snitin315 · snitin315 · commit d0938bdb6b7f · 2021-05-24T19:15:21.000+05:30
diff --git a/client-src/index.js b/client-src/index.js
@@ -140,14 +140,18 @@ const onSocketMessage = {
   // TODO: remove in v5 in favor of 'static-changed'
   'content-changed': function contentChanged(file) {
     log.info(
-      `${file || 'Content'} from static directory was changed. Reloading...`
+      `${
+        file ? `"${file}"` : 'Content'
+      } from static directory was changed. Reloading...`
     );
 
     self.location.reload();
   },
   'static-changed': function staticChanged(file) {
     log.info(
-      `${file || 'Content'} from static directory was changed. Reloading...`
+      `${
+        file ? `"${file}"` : 'Content'
+      } from static directory was changed. Reloading...`
     );
 
     self.location.reload();
diff --git a/test/client/__snapshots__/index.test.js.snap.webpack4 b/test/client/__snapshots__/index.test.js.snap.webpack4
@@ -82,9 +82,11 @@ Array [
 
 exports[`index should run onSocketMessage['content-changed'] 1`] = `"Content from static directory was changed. Reloading..."`;
 
+exports[`index should run onSocketMessage['content-changed'](file) 1`] = `"\\"/public/assets/index.html\\" from static directory was changed. Reloading..."`;
+
 exports[`index should run onSocketMessage['static-changed'] 1`] = `"Content from static directory was changed. Reloading..."`;
 
-exports[`index should run onSocketMessage['static-changed'](file) 1`] = `"/static/assets/index.html from static directory was changed. Reloading..."`;
+exports[`index should run onSocketMessage['static-changed'](file) 1`] = `"\\"/static/assets/index.html\\" from static directory was changed. Reloading..."`;
 
 exports[`index should run onSocketMessage['still-ok'] 1`] = `"Nothing changed."`;
 
diff --git a/test/client/__snapshots__/index.test.js.snap.webpack5 b/test/client/__snapshots__/index.test.js.snap.webpack5
@@ -82,9 +82,11 @@ Array [
 
 exports[`index should run onSocketMessage['content-changed'] 1`] = `"Content from static directory was changed. Reloading..."`;
 
+exports[`index should run onSocketMessage['content-changed'](file) 1`] = `"\\"/public/assets/index.html\\" from static directory was changed. Reloading..."`;
+
 exports[`index should run onSocketMessage['static-changed'] 1`] = `"Content from static directory was changed. Reloading..."`;
 
-exports[`index should run onSocketMessage['static-changed'](file) 1`] = `"/static/assets/index.html from static directory was changed. Reloading..."`;
+exports[`index should run onSocketMessage['static-changed'](file) 1`] = `"\\"/static/assets/index.html\\" from static directory was changed. Reloading..."`;
 
 exports[`index should run onSocketMessage['still-ok'] 1`] = `"Nothing changed."`;
 
diff --git a/test/client/index.test.js b/test/client/index.test.js
@@ -185,6 +185,13 @@ describe('index', () => {
     expect(self.location.reload).toBeCalled();
   });
 
+  test("should run onSocketMessage['content-changed'](file)", () => {
+    onSocketMessage['content-changed']('/public/assets/index.html');
+
+    expect(log.log.info.mock.calls[0][0]).toMatchSnapshot();
+    expect(self.location.reload).toBeCalled();
+  });
+
   test("should run onSocketMessage['static-changed']", () => {
     onSocketMessage['static-changed']();
 
