fix: allow to open browser with --open-page (#3032)

snitin315 · web-flow · commit 581ee07b0c51 · 2021-02-20T15:42:25.000+03:00
diff --git a/lib/Server.js b/lib/Server.js
@@ -662,7 +662,7 @@ class Server {
       );
     }
 
-    if (this.options.open) {
+    if (this.options.open || this.options.openPage) {
       runOpen(localUrlForTerminal, this.options, this.logger);
     }
   }
diff --git a/test/server/open-option.test.js b/test/server/open-option.test.js
@@ -42,6 +42,32 @@ describe('open option', () => {
     server.listen(port, 'localhost');
   });
 
+  it('should work with unspecified open option', (done) => {
+    const compiler = webpack(config);
+    const server = new Server(compiler, {
+      openPage: 'index.html',
+      port,
+      static: false,
+    });
+
+    compiler.hooks.done.tap('webpack-dev-server', () => {
+      server.close(() => {
+        expect(open.mock.calls[1]).toMatchInlineSnapshot(`
+          Array [
+            "http://localhost:8117/index.html",
+            Object {
+              "wait": false,
+            },
+          ]
+        `);
+        done();
+      });
+    });
+
+    compiler.run(() => {});
+    server.listen(port, 'localhost');
+  });
+
   it('should work with "0.0.0.0" host', (done) => {
     const compiler = webpack(config);
     const server = new Server(compiler, {
diff --git a/test/server/utils/runOpen.test.js b/test/server/utils/runOpen.test.js
@@ -119,6 +119,24 @@ describe('runOpen util', () => {
         `);
       }));
 
+    it('on specify URL with openPage option only ', () =>
+      runOpen('https://example.com', { openPage: '/index.html' }, console).then(
+        () => {
+          expect(open).toBeCalledWith('https://example.com/index.html', {
+            wait: false,
+          });
+
+          expect(open.mock.calls[0]).toMatchInlineSnapshot(`
+          Array [
+            "https://example.com/index.html",
+            Object {
+              "wait": false,
+            },
+          ]
+        `);
+        }
+      ));
+
     it('on specify absolute https URL with page in Google Chrome ', () =>
       runOpen(
         'https://example.com',

Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,7 @@ class Server {`
`662`	`662`	`);`
`663`	`663`	`}`
`664`	`664`
`665`		`- if (this.options.open) {`
	`665`	`+ if (this.options.open \|\| this.options.openPage) {`
`666`	`666`	`runOpen(localUrlForTerminal, this.options, this.logger);`
`667`	`667`	`}`
`668`	`668`	`}`