feat: add port "auto" and remove port: null (#3297)

anshumanv · web-flow · commit 437c8d3be704 · 2021-05-15T17:49:42.000+05:30
diff --git a/lib/options.json b/lib/options.json
@@ -174,7 +174,7 @@
               "type": "string"
             },
             {
-              "type": "null"
+              "enum": ["auto"]
             }
           ],
           "description": "Tells clients connected to devServer to use the provided port."
@@ -424,7 +424,7 @@
           "type": "string"
         },
         {
-          "type": "null"
+          "enum": ["auto"]
         }
       ],
       "description": "Specify a port number to listen for requests on. https://webpack.js.org/configuration/dev-server/#devserverport"
diff --git a/lib/utils/findPort.js b/lib/utils/findPort.js
@@ -18,7 +18,7 @@ function runPortFinder() {
 }
 
 function findPort(port) {
-  if (port) {
+  if (port && port !== 'auto') {
     return Promise.resolve(port);
   }
 
diff --git a/test/__snapshots__/validate-options.test.js.snap.webpack4 b/test/__snapshots__/validate-options.test.js.snap.webpack4
@@ -82,12 +82,12 @@ exports[`options validate should throw an error on the "client" option with '{"p
 exports[`options validate should throw an error on the "client" option with '{"port":true}' value 1`] = `
 "ValidationError: Invalid configuration object. Object has been initialized using a configuration object that does not match the API schema.
  - configuration.client.port should be one of these:
-   number | string | null
+   number | string | \\"auto\\"
    -> Tells clients connected to devServer to use the provided port.
    Details:
     * configuration.client.port should be a number.
     * configuration.client.port should be a string.
-    * configuration.client.port should be a null."
+    * configuration.client.port should be \\"auto\\"."
 `;
 
 exports[`options validate should throw an error on the "client" option with '{"progress":""}' value 1`] = `
@@ -361,12 +361,23 @@ exports[`options validate should throw an error on the "open" option with '{"tar
 exports[`options validate should throw an error on the "port" option with 'false' value 1`] = `
 "ValidationError: Invalid configuration object. Object has been initialized using a configuration object that does not match the API schema.
  - configuration.port should be one of these:
-   number | string | null
+   number | string | \\"auto\\"
    -> Specify a port number to listen for requests on. https://webpack.js.org/configuration/dev-server/#devserverport
    Details:
     * configuration.port should be a number.
     * configuration.port should be a string.
-    * configuration.port should be a null."
+    * configuration.port should be \\"auto\\"."
+`;
+
+exports[`options validate should throw an error on the "port" option with 'null' value 1`] = `
+"ValidationError: Invalid configuration object. Object has been initialized using a configuration object that does not match the API schema.
+ - configuration.port should be one of these:
+   number | string | \\"auto\\"
+   -> Specify a port number to listen for requests on. https://webpack.js.org/configuration/dev-server/#devserverport
+   Details:
+    * configuration.port should be a number.
+    * configuration.port should be a string.
+    * configuration.port should be \\"auto\\"."
 `;
 
 exports[`options validate should throw an error on the "proxy" option with '[]' value 1`] = `
diff --git a/test/__snapshots__/validate-options.test.js.snap.webpack5 b/test/__snapshots__/validate-options.test.js.snap.webpack5
@@ -82,12 +82,12 @@ exports[`options validate should throw an error on the "client" option with '{"p
 exports[`options validate should throw an error on the "client" option with '{"port":true}' value 1`] = `
 "ValidationError: Invalid configuration object. Object has been initialized using a configuration object that does not match the API schema.
  - configuration.client.port should be one of these:
-   number | string | null
+   number | string | \\"auto\\"
    -> Tells clients connected to devServer to use the provided port.
    Details:
     * configuration.client.port should be a number.
     * configuration.client.port should be a string.
-    * configuration.client.port should be a null."
+    * configuration.client.port should be \\"auto\\"."
 `;
 
 exports[`options validate should throw an error on the "client" option with '{"progress":""}' value 1`] = `
@@ -361,12 +361,23 @@ exports[`options validate should throw an error on the "open" option with '{"tar
 exports[`options validate should throw an error on the "port" option with 'false' value 1`] = `
 "ValidationError: Invalid configuration object. Object has been initialized using a configuration object that does not match the API schema.
  - configuration.port should be one of these:
-   number | string | null
+   number | string | \\"auto\\"
    -> Specify a port number to listen for requests on. https://webpack.js.org/configuration/dev-server/#devserverport
    Details:
     * configuration.port should be a number.
     * configuration.port should be a string.
-    * configuration.port should be a null."
+    * configuration.port should be \\"auto\\"."
+`;
+
+exports[`options validate should throw an error on the "port" option with 'null' value 1`] = `
+"ValidationError: Invalid configuration object. Object has been initialized using a configuration object that does not match the API schema.
+ - configuration.port should be one of these:
+   number | string | \\"auto\\"
+   -> Specify a port number to listen for requests on. https://webpack.js.org/configuration/dev-server/#devserverport
+   Details:
+    * configuration.port should be a number.
+    * configuration.port should be a string.
+    * configuration.port should be \\"auto\\"."
 `;
 
 exports[`options validate should throw an error on the "proxy" option with '[]' value 1`] = `
diff --git a/test/server/port-option.test.js b/test/server/port-option.test.js
@@ -78,7 +78,7 @@ describe('port', () => {
     afterAll(testServer.close);
   });
 
-  describe('is null', () => {
+  describe('is auto', () => {
     beforeAll((done) => {
       server = testServer.start(
         config,
@@ -87,7 +87,7 @@ describe('port', () => {
             directory: staticDirectory,
             watch: false,
           },
-          port: null,
+          port: 'auto',
         },
         done
       );
diff --git a/test/validate-options.test.js b/test/validate-options.test.js
@@ -70,7 +70,7 @@ const tests = {
       {
         host: '',
         path: '',
-        port: null,
+        port: 'auto',
       },
       {
         progress: false,
@@ -247,8 +247,8 @@ const tests = {
     failure: ['', [], { foo: 'bar' }, { target: 90 }, { app: true }],
   },
   port: {
-    success: ['', 0, null],
-    failure: [false],
+    success: ['', 0, 'auto'],
+    failure: [false, null],
   },
   proxy: {
     success: [

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@`
`174`	`174`	`"type": "string"`
`175`	`175`	`},`
`176`	`176`	`{`
`177`		`- "type": "null"`
	`177`	`+ "enum": ["auto"]`
`178`	`178`	`}`
`179`	`179`	`],`
`180`	`180`	`"description": "Tells clients connected to devServer to use the provided port."`
`@@ -424,7 +424,7 @@`
`424`	`424`	`"type": "string"`
`425`	`425`	`},`
`426`	`426`	`{`
`427`		`- "type": "null"`
	`427`	`+ "enum": ["auto"]`
`428`	`428`	`}`
`429`	`429`	`],`
`430`	`430`	`"description": "Specify a port number to listen for requests on. https://webpack.js.org/configuration/dev-server/#devserverport"`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ function runPortFinder() {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`function findPort(port) {`
`21`		`- if (port) {`
	`21`	`+ if (port && port !== 'auto') {`
`22`	`22`	`return Promise.resolve(port);`
`23`	`23`	`}`
`24`	`24`