Repository navigation
Commit 3b08f15
committed
fix: only exclude an output path nested inside the watched directory
Matching a filesystem-root output path correctly turned out to be worse than
matching it not at all. `output.path` defaults to `/` under an in-memory
filesystem and is routinely left there — test/fixtures/client-config does
exactly that — and `/` contains every static directory there is, so the
watcher stopped reporting anything. CI caught it: "should work and log static
changes" waited 120s for a reload that no longer came.
Exclude an output path only where it is strictly inside the directory being
watched, which is the case the change is for: a build emitting into a folder
that is also served statically. An output path equal to or containing that
folder is left alone, because the user pointed static at it deliberately.
The matcher is now built per watched directory rather than once for the
server, and the new regression test fails against the previous version.1 parent 7284aba commit 3b08f15
4 files changed
Lines changed: 94 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1962 | 1962 | | |
1963 | 1963 | | |
1964 | 1964 | | |
1965 | | - | |
1966 | | - | |
1967 | 1965 | | |
1968 | 1966 | | |
| 1967 | + | |
| 1968 | + | |
1969 | 1969 | | |
1970 | 1970 | | |
1971 | 1971 | | |
| |||
1974 | 1974 | | |
1975 | 1975 | | |
1976 | 1976 | | |
1977 | | - | |
| 1977 | + | |
1978 | 1978 | | |
1979 | 1979 | | |
1980 | 1980 | | |
| |||
1983 | 1983 | | |
1984 | 1984 | | |
1985 | 1985 | | |
1986 | | - | |
1987 | | - | |
| 1986 | + | |
| 1987 | + | |
1988 | 1988 | | |
1989 | 1989 | | |
1990 | | - | |
1991 | | - | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
1992 | 1997 | | |
1993 | | - | |
| 1998 | + | |
| 1999 | + | |
1994 | 2000 | | |
1995 | | - | |
| 2001 | + | |
1996 | 2002 | | |
1997 | 2003 | | |
1998 | 2004 | | |
1999 | | - | |
| 2005 | + | |
| 2006 | + | |
| 2007 | + | |
| 2008 | + | |
| 2009 | + | |
| 2010 | + | |
2000 | 2011 | | |
2001 | | - | |
| 2012 | + | |
| 2013 | + | |
| 2014 | + | |
| 2015 | + | |
| 2016 | + | |
| 2017 | + | |
| 2018 | + | |
2002 | 2019 | | |
2003 | | - | |
2004 | | - | |
2005 | | - | |
2006 | | - | |
2007 | | - | |
| 2020 | + | |
| 2021 | + | |
| 2022 | + | |
2008 | 2023 | | |
2009 | 2024 | | |
2010 | | - | |
2011 | | - | |
2012 | | - | |
2013 | | - | |
| 2025 | + | |
| 2026 | + | |
| 2027 | + | |
| 2028 | + | |
2014 | 2029 | | |
2015 | 2030 | | |
2016 | 2031 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
159 | 205 | | |
160 | 206 | | |
161 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1637 | 1637 | | |
1638 | 1638 | | |
1639 | 1639 | | |
1640 | | - | |
1641 | | - | |
| 1640 | + | |
| 1641 | + | |
1642 | 1642 | | |
1643 | 1643 | | |
1644 | | - | |
1645 | | - | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
1646 | 1651 | | |
1647 | | - | |
| 1652 | + | |
| 1653 | + | |
1648 | 1654 | | |
1649 | 1655 | | |
1650 | 1656 | | |
| |||
0 commit comments