feat: improve error handling within startCallback and endCallback

tehraven · tehraven · commit 27d8518d7626 · 2021-10-23T08:40:30.000-07:00
diff --git a/lib/Server.js b/lib/Server.js
@@ -2175,7 +2175,9 @@ class Server {
   }
 
   startCallback(callback) {
-    this.start().then(() => callback(null), callback);
+    this.start()
+      .then(() => callback(null), callback)
+      .catch(callback);
   }
 
   async stop() {
@@ -2235,7 +2237,9 @@ class Server {
   }
 
   stopCallback(callback) {
-    this.stop().then(() => callback(null), callback);
+    this.stop()
+      .then(() => callback(null), callback)
+      .catch(callback);
   }
 
   // TODO remove in the next major release

Original file line number	Diff line number	Diff line change
`@@ -2175,7 +2175,9 @@ class Server {`
`2175`	`2175`	`}`
`2176`	`2176`
`2177`	`2177`	`startCallback(callback) {`
`2178`		`- this.start().then(() => callback(null), callback);`
	`2178`	`+ this.start()`
	`2179`	`+ .then(() => callback(null), callback)`
	`2180`	`+ .catch(callback);`
`2179`	`2181`	`}`
`2180`	`2182`
`2181`	`2183`	`async stop() {`
`@@ -2235,7 +2237,9 @@ class Server {`
`2235`	`2237`	`}`
`2236`	`2238`
`2237`	`2239`	`stopCallback(callback) {`
`2238`		`- this.stop().then(() => callback(null), callback);`
	`2240`	`+ this.stop()`
	`2241`	`+ .then(() => callback(null), callback)`
	`2242`	`+ .catch(callback);`
`2239`	`2243`	`}`
`2240`	`2244`
`2241`	`2245`	`// TODO remove in the next major release`