-
-
Notifications
You must be signed in to change notification settings - Fork 647
Next #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next #2879
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2879 +/- ##
==========================================
- Coverage 94.95% 93.01% -1.94%
==========================================
Files 31 30 -1
Lines 1704 1647 -57
Branches 484 448 -36
==========================================
- Hits 1618 1532 -86
- Misses 86 115 +29
Continue to review full report at Codecov.
|
| }, | ||
| "engines": { | ||
| "node": ">=10.13.0" | ||
| "node": ">=12.13.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the min for ESM support. Same needed for other subpackages
| "node": ">=12.13.0" | |
| "node": ">=12.22.0" |
| @@ -1 +0,0 @@ | |||
| _ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because husky adds it's install time scripts in this folder that aren't supposed to be tracked
| "jest-watch-typeahead": "^0.6.1", | ||
| "lerna": "^4.0.0", | ||
| "lint-staged": "^10.5.0", | ||
| "lint-staged": "^11.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, this is up to 12 now
What kind of change does this PR introduce?
refactoring + bugfix + features + other
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
It is the next branch
Does this PR introduce a breaking change?
Yes, list of breaking changes will be here in future
Other information
TODO:
drop node v10drop webpack v4 + aliases forwatch(i.e.w),devtool. i.e.d,targetist,output-pathisowere removedprefetch--entryrequire--entry-resetbefore (need add test(s))--targetrequire--target-resetbefore (need add test(s))buildtests - avoid usingscripts/prepareSuite.jsand put all deps in toppackage.json+ rename testsnode-envshould be renamed?getBuiltInOptionsand remove extramap/reduce/etc and avoid usingbuiltInOptionsCacheprocess.exit()webpack versionin favorwebpack info