Skip to content

refactor(generators): leverage helpers#2842

Merged
alexander-akait merged 2 commits intomasterfrom
refactor/generators
Jul 22, 2021
Merged

refactor(generators): leverage helpers#2842
alexander-akait merged 2 commits intomasterfrom
refactor/generators

Conversation

@jamesgeorge007
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary
Move common logic to helper functions.

Does this PR introduce a breaking change?
No

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner July 20, 2021 08:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2021

Codecov Report

Merging #2842 (47661d3) into master (f163f11) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.01%     
==========================================
  Files          32       32              
  Lines        1715     1713       -2     
  Branches      496      494       -2     
==========================================
- Hits         1632     1630       -2     
  Misses         83       83              
Impacted Files Coverage Δ
packages/generators/src/addon-generator.ts 92.59% <100.00%> (+2.27%) ⬆️
packages/generators/src/init-generator.ts 97.95% <100.00%> (+1.46%) ⬆️
packages/generators/src/utils/helpers.ts 85.00% <100.00%> (-15.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f163f11...47661d3. Read the comment docs.

Comment thread packages/generators/src/utils/helpers.ts
Comment thread test/api/generators/helpers.test.js
@alexander-akait alexander-akait merged commit 104b9c4 into master Jul 22, 2021
@alexander-akait alexander-akait deleted the refactor/generators branch July 22, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants