Skip to content

Conversation

@snitin315
Copy link
Member

What kind of change does this PR introduce?
refcator

Did you add tests for your changes?
removed tests
If relevant, did you update the documentation?

Summary
remove --hot, for more context see webpack/webpack-dev-server#3522

Does this PR introduce a breaking change?
Yes

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner July 15, 2021 11:50
@snitin315 snitin315 marked this pull request as draft July 15, 2021 11:52
@alexander-akait
Copy link
Member

The next PRs, drop Node.js 10 and change CI, then let's drop webpack v4 and workaround for webpack v4 (search TODO)

@snitin315
Copy link
Member Author

The next PRs, drop Node.js 10 and change CI, then let's drop webpack v4 and workaround for webpack v4 (search TODO)

On it.

@alexander-akait
Copy link
Member

Need rewrite some tests and delete olds

@snitin315
Copy link
Member Author

Also webpack-dev-server is not yet released with new cli logic and options.

@alexander-akait
Copy link
Member

alexander-akait commented Jul 15, 2021

Hope I will do the next release today/tomorrow (i.e. rc), need finish migration guide, and I am working on it, sorry for delay, really a lot of issues

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@alexander-akait Please review the new changes.

@snitin315 snitin315 closed this Jul 23, 2021
@snitin315 snitin315 reopened this Jul 23, 2021
@snitin315 snitin315 changed the base branch from next to master July 25, 2021 11:45
@snitin315 snitin315 dismissed alexander-akait’s stale review July 25, 2021 11:45

The base branch was changed.

@snitin315 snitin315 changed the base branch from master to next July 25, 2021 11:46
@snitin315
Copy link
Member Author

snitin315 commented Jul 25, 2021

Hmm, this will also drop --hot support for webpack-dev-server@v3, but I think it's fine for next to drop webpack-4 and webpack-dev-server v3.

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #2833 (b1e07f9) into next (104b9c4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2833      +/-   ##
==========================================
- Coverage   95.01%   94.97%   -0.04%     
==========================================
  Files          31       31              
  Lines        1704     1692      -12     
  Branches      496      491       -5     
==========================================
- Hits         1619     1607      -12     
  Misses         85       85              
Impacted Files Coverage Δ
packages/webpack-cli/lib/plugins/CLIPlugin.js 100.00% <ø> (ø)
packages/webpack-cli/lib/webpack-cli.js 96.86% <ø> (-0.01%) ⬇️
packages/serve/src/index.ts 84.07% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104b9c4...b1e07f9. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review July 25, 2021 13:39
@alexander-akait alexander-akait merged commit 43738e6 into next Aug 2, 2021
@alexander-akait alexander-akait deleted the rm-hot branch August 2, 2021 13:13
alexander-akait pushed a commit that referenced this pull request Aug 5, 2021
BRAKING CHANGE:  the `--hot` option was removed for `webpack build` and `webpack watch` commands in favor directly usage `HotModuleReplacement` plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants