test: refactor core-flags tests#2746
Merged
alexander-akait merged 8 commits intomasterfrom Jun 4, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2746 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 31 31
Lines 1634 1634
Branches 476 475 -1
=======================================
Hits 1569 1569
Misses 65 65
Continue to review full report at Codecov.
|
Member
|
Ideally we should not decrease coverage after refactor, i.e. all branches should be passed |
snitin315
force-pushed
the
refactor-core-flags-tests
branch
from
a68f36d to
d93c6f7
Compare
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good work, but we still lose coverage, can you investigate, maybe some kind of small branch is not covered
Member
Author
|
Hmm, looking into it 👍🏻 |
snitin315
force-pushed
the
refactor-core-flags-tests
branch
from
25e1968 to
bcbb590
Compare
Member
|
Looks good, give me time to look at coverage regression |
Member
|
Found, I will fix |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring.
Did you add tests for your changes?
yes, refactor them.
If relevant, did you update the documentation?
No
Summary
WIP
Refactor core-flags tests.
Does this PR introduce a breaking change?
No
Other information
No