Skip to content

fix: dev server 4 migration#2693

Merged
alexander-akait merged 4 commits intomasterfrom
dev-server
May 7, 2021
Merged

fix: dev server 4 migration#2693
alexander-akait merged 4 commits intomasterfrom
dev-server

Conversation

@anshumanv
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
existing

If relevant, did you update the documentation?
NA

Summary

  • Dev server breaking change updates

Does this PR introduce a breaking change?
no

Other information
wip, looking at other changes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2021

Codecov Report

Merging #2693 (7da7822) into master (ea4c159) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
+ Coverage   96.00%   96.13%   +0.13%     
==========================================
  Files          30       30              
  Lines        1526     1526              
  Branches      432      432              
==========================================
+ Hits         1465     1467       +2     
+ Misses         61       59       -2     
Impacted Files Coverage Δ
packages/serve/src/startDevServer.ts 92.98% <0.00%> (+1.75%) ⬆️
packages/generators/src/addon-generator.ts 92.98% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4c159...7da7822. Read the comment docs.

@alexander-akait
Copy link
Copy Markdown
Member

@anshumanv please update snapshots

@anshumanv
Copy link
Copy Markdown
Member Author

yep on it 👍

Comment thread .github/workflows/nodejs.yml
@anshumanv anshumanv marked this pull request as ready for review May 7, 2021 05:58
@anshumanv anshumanv requested a review from a team as a code owner May 7, 2021 05:58
@anshumanv
Copy link
Copy Markdown
Member Author

/cc @webpack/cli-team

@alexander-akait alexander-akait merged commit 1f04b1a into master May 7, 2021
@alexander-akait alexander-akait deleted the dev-server branch May 7, 2021 13:15
@alexander-akait
Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants